Avoid using CompletableFuture.whenCompleteAsync() #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91de14a to
bc989d9
Compare
anuraaga
approved these changes
Nov 15, 2018
Related: line#1426 Motivation: `CompletableFuture` always creates a new `CompletionException` after it calls the callback registered with `whenCompleteAsync()`, even if there are no dependants and the `CompletionException` will never be used. See https://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/java.base/share/classes/java/util/concurrent/CompletableFuture.java#l870 for more information. Modifications: - Use `CompletableFuture.handleAsync()` instead of `whenCompleteAsync()`. - Miscellaneous: - Avoid using `voidFunction()` which increases the level of indirection Result: - Fixes line#1426 - Better performance master: Benchmark (clientType) Mode Cnt Score Error Units DownstreamSimpleBenchmark.empty NORMAL thrpt 100 52167.567 ± 274.358 ops/s This pull request: Benchmark (clientType) Mode Cnt Score Error Units DownstreamSimpleBenchmark.empty NORMAL thrpt 100 58171.594 ± 365.014 ops/s
bc989d9 to
93df38b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1440 +/- ##
==========================================
- Coverage 72.62% 72.57% -0.06%
==========================================
Files 617 617
Lines 26820 26832 +12
Branches 3245 3245
==========================================
- Hits 19477 19472 -5
- Misses 5636 5655 +19
+ Partials 1707 1705 -2
Continue to review full report at Codecov.
|
|
Ran the benchmark again today for #1444 and the throughput of this pull request is now around 54,000-56,000. Maybe not as dramatic as initially observed, although it's still quite an improvement. |
trustin
added a commit
that referenced
this pull request
Nov 16, 2018
trustin
added a commit
to trustin/armeria
that referenced
this pull request
Feb 15, 2019
Motivation: As we discovered in line#1440, `whenComplete()` is harmful for performance. Modifications: - Use `handle()` instead of `whenComplete()` Result: - Potentially less unnecessary instantiation of `CompletionException`.
trustin
added a commit
that referenced
this pull request
Feb 15, 2019
Motivation: As we discovered in #1440, `whenComplete()` is harmful for performance. Modifications: - Use `handle()` instead of `whenComplete()` Result: - Potentially less unnecessary instantiation of `CompletionException`.
Merged
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Related: line#1426 Motivation: `CompletableFuture` always creates a new `CompletionException` after it calls the callback registered with `whenCompleteAsync()`, even if there are no dependants and the `CompletionException` will never be used. See https://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/java.base/share/classes/java/util/concurrent/CompletableFuture.java#l870 for more information. Modifications: - Use `CompletableFuture.handleAsync()` instead of `whenCompleteAsync()`. - Miscellaneous: - Avoid using `voidFunction()` which increases the level of indirection Result: - Fixes line#1426 - Better performance master: Benchmark (clientType) Mode Cnt Score Error Units DownstreamSimpleBenchmark.empty NORMAL thrpt 100 52167.567 ± 274.358 ops/s This pull request: Benchmark (clientType) Mode Cnt Score Error Units DownstreamSimpleBenchmark.empty NORMAL thrpt 100 58171.594 ± 365.014 ops/s
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: As we discovered in line#1440, `whenComplete()` is harmful for performance. Modifications: - Use `handle()` instead of `whenComplete()` Result: - Potentially less unnecessary instantiation of `CompletionException`.
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1426
Motivation:
CompletableFuturealways creates a newCompletionExceptionafter itcalls the callback registered with
whenCompleteAsync(), even if thereare no dependants and the
CompletionExceptionwill never be used.See https://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/java.base/share/classes/java/util/concurrent/CompletableFuture.java#l870
for more information.
Modifications:
CompletableFuture.handleAsync()instead ofwhenCompleteAsync().voidFunction()which increases the level of indirectionResult:
master:
This pull request: