-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[Github][CI] Rename New Premerge Jobs #138024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This patch renames the new premerge job as suggested in https://discourse.llvm.org/t/github-ci-notifications-and-main-branch/85868/10. This uses more industry standard terms (like CI vs premerge checks which might be somewhat of a LLVM CI idiom?) and makes it more generic if we end up doing postcommit testing through Github.
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch renames the new premerge job as suggested in https://discourse.llvm.org/t/github-ci-notifications-and-main-branch/85868/10. This uses more industry standard terms (like CI vs premerge checks which might be somewhat of a LLVM CI idiom?) and makes it more generic if we end up doing postcommit testing through Github. Full diff: https://github.com/llvm/llvm-project/pull/138024.diff 2 Files Affected:
diff --git a/.ci/metrics/metrics.py b/.ci/metrics/metrics.py
index a5ee893650d63..5c53ebf6ade02 100644
--- a/.ci/metrics/metrics.py
+++ b/.ci/metrics/metrics.py
@@ -29,8 +29,8 @@
# name.
GITHUB_JOB_TO_TRACK = {
"github_llvm_premerge_checks": {
- "Linux Premerge Checks (Test Only - Please Ignore Results)": "premerge_linux",
- "Windows Premerge Checks (Test Only - Please Ignore Results)": "premerge_windows",
+ "Build and Test Linux (Test Only - Please Ignore Results)": "premerge_linux",
+ "Build and Test Windows (Test Only - Please Ignore Results)": "premerge_windows",
}
}
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index c315ee37646d2..5defe92debd6b 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -1,4 +1,4 @@
-name: LLVM Premerge Checks
+name: LLVM CI Checks
permissions:
contents: read
@@ -25,7 +25,7 @@ concurrency:
jobs:
premerge-checks-linux:
- name: Linux Premerge Checks (Test Only - Please Ignore Results)
+ name: Build and Test Linux (Test Only - Please Ignore Results)
if: >-
github.repository_owner == 'llvm' &&
(github.event_name != 'pull_request' || github.event.action != 'closed')
@@ -74,7 +74,7 @@ jobs:
include-hidden-files: 'true'
premerge-checks-windows:
- name: Windows Premerge Checks (Test Only - Please Ignore Results)
+ name: Build and Test Windows (Test Only - Please Ignore Results)
if: >-
github.repository_owner == 'llvm' &&
(github.event_name != 'pull_request' || github.event.action != 'closed')
|
This patch renames the new premerge job as suggested in https://discourse.llvm.org/t/github-ci-notifications-and-main-branch/85868/10. This uses more industry standard terms (like CI vs premerge checks which might be somewhat of a LLVM CI idiom?) and makes it more generic if we end up doing postcommit testing through Github.
This patch renames the new premerge job as suggested in https://discourse.llvm.org/t/github-ci-notifications-and-main-branch/85868/10. This uses more industry standard terms (like CI vs premerge checks which might be somewhat of a LLVM CI idiom?) and makes it more generic if we end up doing postcommit testing through Github.
This patch renames the new premerge job as suggested in https://discourse.llvm.org/t/github-ci-notifications-and-main-branch/85868/10. This uses more industry standard terms (like CI vs premerge checks which might be somewhat of a LLVM CI idiom?) and makes it more generic if we end up doing postcommit testing through Github.
This patch renames the new premerge job as suggested in https://discourse.llvm.org/t/github-ci-notifications-and-main-branch/85868/10. This uses more industry standard terms (like CI vs premerge checks which might be somewhat of a LLVM CI idiom?) and makes it more generic if we end up doing postcommit testing through Github.
This patch renames the new premerge job as suggested in https://discourse.llvm.org/t/github-ci-notifications-and-main-branch/85868/10. This uses more industry standard terms (like CI vs premerge checks which might be somewhat of a LLVM CI idiom?) and makes it more generic if we end up doing postcommit testing through Github.