[WIP] MSC2271 TOTP 2FA login #2271
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent. But a separate proposal for U2F/WebAuthn? |
ptman
reviewed
Sep 30, 2019
| Returns: `{"totp_key": "keyhere", "backup_keys": ["a", "b", "c"]}` | ||
|
|
||
| `DELETE /_matrix/client/r0/user/{user_id}/totp` | ||
| Remove TOTP from the account. Require password as a parameter (?) |
There was a problem hiding this comment.
Other services I've seen allow you to remove 2FA tokens without having to auth the 2FA (only requiring password for confirmation). Of course you do need to be logged in already.
There was a problem hiding this comment.
I think I've had the opposite experience, but can't name a service off-hand
There was a problem hiding this comment.
I think this endpoint should just require user interactive auth, like other security sensitive endpoints do. The server could then decide, if you need to provide the password, password+totp token, password+totp recovery key, or any other combination, just like the usual flows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level proposal for TOTP 2FA auth from @hawkowl
Rendered