MSC3982: Limit maximum number of events sent to an AS #3982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
commented
Mar 21, 2023
|
|
||
| - This requires a two way communication between the Homeserver and AS, which presently isn't required. | ||
| - This potentially costs more time in negotiation than any efficiency losses from the hardcoded limit. | ||
| - Practically speaking, Synapse [has had a limit of 100](https://github.com/matrix-org/synapse/blob/develop/synapse/appservice/scheduler.py#L85-L86) |
There was a problem hiding this comment.
For other homeserver implementations:
- Dendrite has a limit of 50 https://github.com/matrix-org/dendrite/blob/main/appservice/consumers/roomserver.go#L84
- Conduit has a limit of 30 https://gitlab.com/famedly/conduit/-/blob/next/src/service/sending/mod.rs#L159 (I think, it's kinda hard to follow)
clokep
reviewed
Mar 21, 2023
clokep
reviewed
Mar 21, 2023
Comment on lines
+53
to
+54
| Potentially the homeserver and application service could negotiate a maximum event size instead of specifying | ||
| one in the spec, however this isn't desirable because: |
There was a problem hiding this comment.
Another reason this is not reasonable is that neither Synapse nor the application service know about any middle boxes between them, so neither of them can possibly know the maximum HTTP request size that is allowed without trial & error.
clokep
reviewed
Mar 21, 2023
|
Synapse seems to implement this already, so I think needs-implementation can go away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Fixes matrix-org/matrix-spec#1469
Implementations: