Experiment short-circuiting of union distribution #50640

Zzzen · 2022-09-05T15:48:35Z

Tried the following code on my machine, the check time is reduced from 24s to 6s. I'd like to see how it works for RWC.

type HugeUnion1 = "a" | "q" | ... [10,000 more];
type HugeUnion2 = "a" | ... [10,000 more which do not include 'q'];

type Square<T, U> = T extends U ? true : false;

type M = Square<HugeUnion1, HugeUnion2>;

jakebailey · 2022-09-09T06:01:02Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot test top100

typescript-bot · 2022-09-09T06:01:05Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at cd31843. You can monitor the build here.

typescript-bot · 2022-09-09T06:01:05Z

Heya @jakebailey, I've started to run the extended test suite on this PR at cd31843. You can monitor the build here.

typescript-bot · 2022-09-09T06:01:05Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at cd31843. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-09T06:01:05Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at cd31843. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-09T06:01:06Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at cd31843. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-09T06:15:11Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50640

_Metric	_main	₅₀₆₄₀	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{338,844k (± 0.00%)}	_{338,845k (± 0.01%)}	_{+1k (+ 0.00%)}	_338,744k	_338,888k
_{Parse Time}	_{2.07s (± 0.89%)}	_{2.06s (± 0.24%)}	_{-0.00s (- 0.19%)}	_2.05s	_2.07s
_{Bind Time}	_{0.80s (± 0.46%)}	_{0.79s (± 0.66%)}	_{-0.01s (- 0.63%)}	_0.78s	_0.80s
_{Check Time}	_{5.82s (± 0.42%)}	_{5.81s (± 0.32%)}	_{-0.01s (- 0.24%)}	_5.78s	_5.88s
_{Emit Time}	_{6.13s (± 0.74%)}	_{6.14s (± 0.49%)}	_{+0.00s (+ 0.05%)}	_6.08s	_6.22s
_{Total Time}	_{14.82s (± 0.41%)}	_{14.80s (± 0.32%)}	_{-0.02s (- 0.15%)}	_14.73s	_14.97s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,644k (± 0.02%)}	_{192,842k (± 0.25%)}	_{+198k (+ 0.10%)}	_192,578k	_194,784k
_{Parse Time}	_{0.85s (± 0.72%)}	_{0.85s (± 0.76%)}	_{+0.00s (+ 0.12%)}	_0.84s	_0.87s
_{Bind Time}	_{0.48s (± 0.70%)}	_{0.48s (± 0.00%)}	_{-0.00s (- 0.62%)}	_0.48s	_0.48s
_{Check Time}	_{6.71s (± 0.50%)}	_{6.71s (± 0.66%)}	_{+0.00s (+ 0.03%)}	_6.64s	_6.83s
_{Emit Time}	_{2.41s (± 0.71%)}	_{2.43s (± 1.32%)}	_{+0.02s (+ 0.66%)}	_2.38s	_2.54s
_{Total Time}	_{10.46s (± 0.28%)}	_{10.47s (± 0.59%)}	_{+0.02s (+ 0.15%)}	_10.38s	_10.64s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,531k (± 0.01%)}	_{326,522k (± 0.00%)}	_{-9k (- 0.00%)}	_326,499k	_326,535k
_{Parse Time}	_{1.57s (± 0.79%)}	_{1.56s (± 0.31%)}	_{-0.01s (- 0.38%)}	_1.55s	_1.57s
_{Bind Time}	_{0.73s (± 0.65%)}	_{0.72s (± 1.05%)}	_{-0.00s (- 0.28%)}	_0.71s	_0.75s
_{Check Time}	_{5.71s (± 0.54%)}	_{5.71s (± 0.53%)}	_{+0.00s (+ 0.07%)}	_5.64s	_5.77s
_{Emit Time}	_{3.33s (± 0.63%)}	_{3.31s (± 0.60%)}	_{-0.01s (- 0.39%)}	_3.26s	_3.35s
_{Total Time}	_{11.33s (± 0.33%)}	_{11.31s (± 0.34%)}	_{-0.02s (- 0.16%)}	_11.22s	_11.38s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,654k (± 0.01%)}	_{289,648k (± 0.01%)}	_{-7k (- 0.00%)}	_289,596k	_289,713k
_{Parse Time}	_{1.30s (± 0.64%)}	_{1.30s (± 1.42%)}	_{+0.01s (+ 0.62%)}	_1.28s	_1.37s
_{Bind Time}	_{0.79s (± 1.01%)}	_{0.79s (± 1.65%)}	_{-0.01s (- 0.76%)}	_0.74s	_0.81s
_{Check Time}	_{5.35s (± 0.23%)}	_{5.35s (± 0.41%)}	_{-0.00s (- 0.02%)}	_5.30s	_5.40s
_{Emit Time}	_{3.57s (± 0.73%)}	_{3.56s (± 0.79%)}	_{-0.01s (- 0.28%)}	_3.49s	_3.62s
_{Total Time}	_{11.00s (± 0.30%)}	_{11.00s (± 0.24%)}	_{-0.01s (- 0.05%)}	_10.94s	_11.04s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{436,462k (± 0.01%)}	_{436,556k (± 0.01%)}	_{+94k (+ 0.02%)}	_436,494k	_436,604k
_{Parse Time}	_{1.85s (± 0.37%)}	_{1.86s (± 0.56%)}	_{+0.01s (+ 0.43%)}	_1.83s	_1.88s
_{Bind Time}	_{0.58s (± 0.57%)}	_{0.58s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.58s	_0.58s
_{Check Time}	_{12.85s (± 0.49%)}	_{12.86s (± 0.56%)}	_{+0.01s (+ 0.08%)}	_12.74s	_13.03s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.29s (± 0.40%)}	_{15.31s (± 0.47%)}	_{+0.02s (+ 0.14%)}	_15.20s	_15.47s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{546,728k (± 0.00%)}	_{546,768k (± 0.00%)}	_{+41k (+ 0.01%)}	_546,746k	_546,791k
_{Parse Time}	_{2.59s (± 0.45%)}	_{2.59s (± 0.36%)}	_{+0.00s (+ 0.15%)}	_2.57s	_2.61s
_{Bind Time}	_{0.96s (± 0.38%)}	_{0.97s (± 1.71%)}	_{+0.01s (+ 1.04%)}	_0.96s	_1.03s
_{Check Time}	_{1.51s (± 0.40%)}	_{1.52s (± 0.43%)}	_{+0.01s (+ 0.46%)}	_1.51s	_1.54s
_{Emit Time}	_{0.07s (± 4.13%)}	_{0.07s (± 3.14%)}	_{-0.00s (- 1.39%)}	_0.07s	_0.08s
_{Total Time}	_{5.14s (± 0.22%)}	_{5.16s (± 0.42%)}	_{+0.02s (+ 0.33%)}	_5.12s	_5.23s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₄₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-09-09T06:16:32Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/50640/merge:

Everything looks good!

typescript-bot · 2022-09-09T07:38:05Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/50640/merge:

Everything looks good!

jakebailey · 2022-09-09T07:38:21Z

I feel like something's wrong with RWC; if doesn't reply?

typescript-bot · 2022-09-14T20:25:24Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50640

_Metric	_main	₅₀₆₄₀	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{338,937k (± 0.01%)}	_{338,940k (± 0.01%)}	_{+2k (+ 0.00%)}	_338,885k	_339,018k
_{Parse Time}	_{2.06s (± 0.61%)}	_{2.05s (± 0.33%)}	_{-0.00s (- 0.24%)}	_2.04s	_2.07s
_{Bind Time}	_{0.80s (± 1.03%)}	_{0.80s (± 0.47%)}	_{-0.00s (- 0.25%)}	_0.79s	_0.80s
_{Check Time}	_{5.83s (± 0.42%)}	_{5.84s (± 0.31%)}	_{+0.01s (+ 0.14%)}	_5.80s	_5.88s
_{Emit Time}	_{6.19s (± 0.43%)}	_{6.17s (± 0.75%)}	_{-0.02s (- 0.26%)}	_6.04s	_6.26s
_{Total Time}	_{14.88s (± 0.27%)}	_{14.86s (± 0.39%)}	_{-0.01s (- 0.08%)}	_14.70s	_14.96s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{190,140k (± 0.01%)}	_{192,402k (± 1.12%)}	_{+2,262k (+ 1.19%)}	_189,377k	_195,989k
_{Parse Time}	_{0.85s (± 0.40%)}	_{0.90s (± 6.92%)}	_{+0.05s (+ 5.86%)}	_0.84s	_1.13s
_{Bind Time}	_{0.48s (± 0.77%)}	_{0.53s (±10.02%)}	_{+0.04s (+ 8.87%)}	_0.48s	_0.73s
_{Check Time}	_{6.76s (± 0.70%)}	_{7.19s (± 6.00%)}	_{+0.43s (+ 6.38%)}	_6.64s	_8.28s
_{Emit Time}	_{2.38s (± 0.92%)}	_{2.52s (± 4.92%)}	_{+0.14s (+ 6.01%)}	_2.37s	_2.94s
_{Total Time}	_{10.48s (± 0.59%)}	_{11.14s (± 5.72%)}	_{+0.66s (+ 6.33%)}	_10.37s	_12.82s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,575k (± 0.01%)}	_{326,548k (± 0.01%)}	_{-27k (- 0.01%)}	_326,446k	_326,612k
_{Parse Time}	_{1.59s (± 0.79%)}	_{1.61s (± 3.97%)}	_{+0.03s (+ 1.57%)}	_1.57s	_1.87s
_{Bind Time}	_{0.73s (± 0.47%)}	_{0.73s (± 1.21%)}	_{+0.01s (+ 0.96%)}	_0.72s	_0.76s
_{Check Time}	_{5.74s (± 0.53%)}	_{5.75s (± 1.25%)}	_{+0.01s (+ 0.19%)}	_5.64s	_5.99s
_{Emit Time}	_{3.35s (± 0.65%)}	_{3.33s (± 1.11%)}	_{-0.02s (- 0.54%)}	_3.26s	_3.42s
_{Total Time}	_{11.40s (± 0.41%)}	_{11.42s (± 1.35%)}	_{+0.02s (+ 0.22%)}	_11.24s	_11.99s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,703k (± 0.01%)}	_{289,694k (± 0.01%)}	_{-9k (- 0.00%)}	_289,640k	_289,724k
_{Parse Time}	_{1.31s (± 0.59%)}	_{1.30s (± 0.46%)}	_{-0.01s (- 1.07%)}	_1.28s	_1.31s
_{Bind Time}	_{0.79s (± 2.25%)}	_{0.80s (± 0.70%)}	_{+0.01s (+ 1.14%)}	_0.79s	_0.81s
_{Check Time}	_{5.35s (± 0.39%)}	_{5.34s (± 0.34%)}	_{-0.01s (- 0.15%)}	_5.30s	_5.38s
_{Emit Time}	_{3.54s (± 0.89%)}	_{3.54s (± 0.51%)}	_{+0.01s (+ 0.28%)}	_3.51s	_3.58s
_{Total Time}	_{10.98s (± 0.39%)}	_{10.98s (± 0.25%)}	_{-0.00s (- 0.02%)}	_10.94s	_11.07s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{436,655k (± 0.00%)}	_{436,737k (± 0.00%)}	_{+83k (+ 0.02%)}	_436,690k	_436,794k
_{Parse Time}	_{1.88s (± 0.64%)}	_{1.87s (± 0.76%)}	_{-0.00s (- 0.16%)}	_1.86s	_1.92s
_{Bind Time}	_{0.59s (± 1.16%)}	_{0.59s (± 0.76%)}	_{+0.00s (+ 0.34%)}	_0.58s	_0.60s
_{Check Time}	_{12.91s (± 0.77%)}	_{12.95s (± 1.02%)}	_{+0.05s (+ 0.35%)}	_12.78s	_13.44s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.37s (± 0.71%)}	_{15.41s (± 0.89%)}	_{+0.04s (+ 0.29%)}	_15.22s	_15.89s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{546,986k (± 0.00%)}	_{547,013k (± 0.00%)}	_{+27k (+ 0.00%)}	_546,982k	_547,055k
_{Parse Time}	_{2.60s (± 0.43%)}	_{2.61s (± 0.52%)}	_{+0.01s (+ 0.19%)}	_2.59s	_2.64s
_{Bind Time}	_{0.99s (± 1.23%)}	_{0.98s (± 0.59%)}	_{-0.01s (- 1.21%)}	_0.97s	_0.99s
_{Check Time}	_{1.52s (± 0.49%)}	_{1.53s (± 0.58%)}	_{+0.01s (+ 0.46%)}	_1.51s	_1.55s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.19s (± 0.29%)}	_{5.19s (± 0.29%)}	_{-0.00s (- 0.08%)}	_5.16s	_5.23s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₄₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

sandersn · 2022-09-21T23:08:13Z

@typescript-bot perf test this faster

typescript-bot · 2022-09-21T23:08:16Z

Heya @sandersn, I've started to run the abridged perf test suite on this PR at cd31843. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-22T00:14:40Z

@sandersn
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50640

_Metric	_main	₅₀₆₄₀	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{339,148k (± 0.01%)}	_{339,161k (± 0.00%)}	_{+13k (+ 0.00%)}	_339,131k	_339,180k
_{Parse Time}	_{2.06s (± 0.44%)}	_{2.06s (± 0.80%)}	_{+0.00s (+ 0.19%)}	_2.03s	_2.11s
_{Bind Time}	_{0.80s (± 0.75%)}	_{0.79s (± 0.75%)}	_{-0.00s (- 0.13%)}	_0.78s	_0.81s
_{Check Time}	_{5.87s (± 0.54%)}	_{5.86s (± 0.31%)}	_{-0.01s (- 0.10%)}	_5.82s	_5.90s
_{Emit Time}	_{6.23s (± 0.46%)}	_{6.24s (± 0.45%)}	_{+0.01s (+ 0.11%)}	_6.18s	_6.30s
_{Total Time}	_{14.95s (± 0.29%)}	_{14.96s (± 0.29%)}	_{+0.01s (+ 0.05%)}	_14.85s	_15.07s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{190,791k (± 0.68%)}	_{190,124k (± 0.13%)}	_{-667k (- 0.35%)}	_189,123k	_190,350k
_{Parse Time}	_{0.86s (± 0.43%)}	_{0.85s (± 0.40%)}	_{-0.00s (- 0.35%)}	_0.85s	_0.86s
_{Bind Time}	_{0.48s (± 0.70%)}	_{0.48s (± 0.70%)}	_{0.00s ( 0.00%)}	_0.48s	_0.49s
_{Check Time}	_{6.77s (± 0.45%)}	_{6.72s (± 0.30%)}	_{-0.04s (- 0.62%)}	_6.69s	_6.77s
_{Emit Time}	_{2.40s (± 0.92%)}	_{2.43s (± 1.75%)}	_{+0.02s (+ 1.00%)}	_2.37s	_2.58s
_{Total Time}	_{10.51s (± 0.39%)}	_{10.49s (± 0.51%)}	_{-0.02s (- 0.17%)}	_10.42s	_10.68s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,591k (± 0.01%)}	_{326,562k (± 0.01%)}	_{-29k (- 0.01%)}	_326,497k	_326,602k
_{Parse Time}	_{1.59s (± 0.83%)}	_{1.58s (± 0.37%)}	_{-0.01s (- 0.94%)}	_1.57s	_1.59s
_{Bind Time}	_{0.73s (± 0.47%)}	_{0.72s (± 0.41%)}	_{-0.01s (- 0.69%)}	_0.72s	_0.73s
_{Check Time}	_{5.73s (± 0.46%)}	_{5.69s (± 0.48%)}	_{-0.04s (- 0.70%)}	_5.65s	_5.74s
_{Emit Time}	_{3.38s (± 0.76%)}	_{3.38s (± 0.49%)}	_{-0.00s (- 0.12%)}	_3.35s	_3.42s
_{Total Time}	_{11.44s (± 0.38%)}	_{11.37s (± 0.34%)}	_{-0.06s (- 0.54%)}	_11.31s	_11.45s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,679k (± 0.01%)}	_{289,686k (± 0.00%)}	_{+7k (+ 0.00%)}	_289,663k	_289,711k
_{Parse Time}	_{1.30s (± 0.78%)}	_{1.29s (± 0.46%)}	_{-0.01s (- 0.46%)}	_1.28s	_1.31s
_{Bind Time}	_{0.79s (± 0.56%)}	_{0.79s (± 2.00%)}	_{-0.01s (- 0.88%)}	_0.74s	_0.80s
_{Check Time}	_{5.38s (± 0.52%)}	_{5.39s (± 0.34%)}	_{+0.00s (+ 0.04%)}	_5.35s	_5.44s
_{Emit Time}	_{3.60s (± 0.80%)}	_{3.59s (± 0.82%)}	_{-0.00s (- 0.06%)}	_3.55s	_3.69s
_{Total Time}	_{11.07s (± 0.37%)}	_{11.06s (± 0.34%)}	_{-0.01s (- 0.13%)}	_10.96s	_11.14s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{436,854k (± 0.00%)}	_{436,912k (± 0.00%)}	_{+59k (+ 0.01%)}	_436,872k	_436,958k
_{Parse Time}	_{1.87s (± 0.70%)}	_{1.86s (± 0.45%)}	_{-0.01s (- 0.54%)}	_1.85s	_1.88s
_{Bind Time}	_{0.58s (± 0.85%)}	_{0.58s (± 0.81%)}	_{-0.01s (- 0.85%)}	_0.57s	_0.59s
_{Check Time}	_{12.85s (± 0.28%)}	_{12.81s (± 0.39%)}	_{-0.03s (- 0.26%)}	_12.69s	_12.93s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.30s (± 0.27%)}	_{15.25s (± 0.30%)}	_{-0.05s (- 0.30%)}	_15.15s	_15.36s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{547,657k (± 0.00%)}	_{547,693k (± 0.00%)}	_{+36k (+ 0.01%)}	_547,662k	_547,725k
_{Parse Time}	_{2.62s (± 0.58%)}	_{2.61s (± 0.49%)}	_{-0.01s (- 0.34%)}	_2.59s	_2.65s
_{Bind Time}	_{0.98s (± 1.38%)}	_{0.98s (± 1.23%)}	_{-0.00s (- 0.20%)}	_0.95s	_1.01s
_{Check Time}	_{1.51s (± 0.61%)}	_{1.51s (± 0.45%)}	_{+0.00s (+ 0.13%)}	_1.50s	_1.53s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.19s (± 0.40%)}	_{5.18s (± 0.29%)}	_{-0.01s (- 0.19%)}	_5.16s	_5.22s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₄₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

jakebailey · 2022-09-22T00:16:34Z

Yeah, when I ran it, it didn't seem like we saw a boost, but we probably don't have something so bad in our test suite.

jakebailey · 2023-01-27T05:18:14Z

@Zzzen I took the liberty of merging main into this to retest it; hope you don't mind.

@typescript-bot perf test this

typescript-bot · 2023-01-27T05:18:17Z

Heya @jakebailey, I've started to run the perf test suite on this PR at 8f978fd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-27T06:18:57Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50640

_Metric	_main	₅₀₆₄₀	_Delta	_Best	_Worst
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,834k (± 0.03%)}	_{359,817k (± 0.01%)}	_{-16k (- 0.00%)}	_359,768k	_359,897k
_{Parse Time}	_{3.96s (± 0.87%)}	_{3.97s (± 0.34%)}	_{+0.01s (+ 0.25%)}	_3.95s	_3.99s
_{Bind Time}	_{1.18s (± 0.69%)}	_{1.17s (± 0.64%)}	_{-0.00s (- 0.42%)}	_1.16s	_1.18s
_{Check Time}	_{8.66s (± 0.31%)}	_{8.67s (± 0.63%)}	_{+0.01s (+ 0.10%)}	_8.57s	_8.72s
_{Emit Time}	_{7.65s (± 0.93%)}	_{7.61s (± 0.76%)}	_{-0.04s (- 0.52%)}	_7.51s	_7.68s
_{Total Time}	_{21.44s (± 0.27%)}	_{21.41s (± 0.42%)}	_{-0.03s (- 0.12%)}	_21.30s	_21.50s
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{193,493k (± 1.19%)}	_{192,531k (± 0.06%)}	_{-963k (- 0.50%)}	_192,307k	_192,609k
_{Parse Time}	_{1.64s (± 1.37%)}	_{1.65s (± 3.12%)}	_{+0.01s (+ 0.51%)}	_1.61s	_1.72s
_{Bind Time}	_{0.79s (± 0.69%)}	_{0.79s (± 0.69%)}	_{0.00s ( 0.00%)}	_0.79s	_0.80s
_{Check Time}	_{9.62s (± 0.60%)}	_{9.66s (± 0.49%)}	_{+0.05s (+ 0.47%)}	_9.61s	_9.73s
_{Emit Time}	_{2.80s (± 0.43%)}	_{2.87s (± 4.95%)}	_{+0.06s (+ 2.20%)}	_2.79s	_3.15s
_{Total Time}	_{14.86s (± 0.58%)}	_{14.97s (± 0.62%)}	_{+0.11s (+ 0.76%)}	_14.89s	_15.15s
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{344,010k (± 0.01%)}	_{343,990k (± 0.01%)}	_{-20k (- 0.01%)}	_343,922k	_344,030k
_{Parse Time}	_{2.94s (± 0.61%)}	_{2.97s (± 0.84%)}	_{+0.03s (+ 0.96%)}	_2.94s	_3.00s
_{Bind Time}	_{1.03s (± 0.79%)}	_{1.04s (± 1.59%)}	_{+0.00s (+ 0.16%)}	_1.02s	_1.05s
_{Check Time}	_{7.06s (± 0.65%)}	_{7.07s (± 0.67%)}	_{+0.01s (+ 0.19%)}	_7.00s	_7.13s
_{Emit Time}	_{4.32s (± 0.74%)}	_{4.35s (± 0.44%)}	_{+0.03s (+ 0.66%)}	_4.33s	_4.37s
_{Total Time}	_{15.35s (± 0.57%)}	_{15.42s (± 0.35%)}	_{+0.07s (+ 0.46%)}	_15.33s	_15.47s
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,383k (± 0.00%)}	_{300,372k (± 0.00%)}	_{-11k (- 0.00%)}	_300,360k	_300,383k
_{Parse Time}	_{2.24s (± 1.53%)}	_{2.25s (± 1.18%)}	_{+0.01s (+ 0.45%)}	_2.21s	_2.29s
_{Bind Time}	_{1.17s (± 0.70%)}	_{1.17s (± 0.71%)}	_{+0.00s (+ 0.14%)}	_1.17s	_1.19s
_{Check Time}	_{6.52s (± 0.57%)}	_{6.53s (± 0.42%)}	_{+0.00s (+ 0.08%)}	_6.48s	_6.56s
_{Emit Time}	_{3.91s (± 0.53%)}	_{3.93s (± 1.27%)}	_{+0.02s (+ 0.55%)}	_3.88s	_4.00s
_{Total Time}	_{13.85s (± 0.58%)}	_{13.89s (± 0.48%)}	_{+0.04s (+ 0.26%)}	_13.79s	_13.96s
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,755k (± 0.01%)}	_{476,825k (± 0.02%)}	_{+70k (+ 0.01%)}	_476,715k	_476,972k
_{Parse Time}	_{3.55s (± 0.92%)}	_{3.57s (± 1.04%)}	_{+0.03s (+ 0.75%)}	_3.51s	_3.61s
_{Bind Time}	_{0.96s (± 1.09%)}	_{0.97s (± 0.84%)}	_{+0.01s (+ 0.86%)}	_0.96s	_0.98s
_{Check Time}	_{17.09s (± 0.49%)}	_{17.25s (± 0.70%)}	_{+0.16s (+ 0.92%)}	_17.08s	_17.39s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{21.60s (± 0.48%)}	_{21.80s (± 0.51%)}	_{+0.19s (+ 0.90%)}	_21.66s	_21.97s
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{548,660k (± 0.03%)}	_{548,631k (± 0.02%)}	_{-29k (- 0.01%)}	_548,500k	_548,869k
_{Parse Time}	_{4.57s (± 0.52%)}	_{4.60s (± 0.54%)}	_{+0.03s (+ 0.73%)}	_4.58s	_4.65s
_{Bind Time}	_{1.72s (± 0.48%)}	_{1.72s (± 0.61%)}	_{-0.01s (- 0.58%)}	_1.70s	_1.73s
_{Check Time}	_{2.73s (± 0.80%)}	_{2.77s (± 0.55%)}	_{+0.03s (+ 1.28%)}	_2.74s	_2.78s
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_{+0.00s (+ 2.08%)}	_0.08s	_0.09s
_{Total Time}	_{9.12s (± 0.44%)}	_{9.17s (± 0.41%)}	_{+0.06s (+ 0.66%)}	_9.14s	_9.24s
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,218k (± 0.00%)}	_{359,202k (± 0.01%)}	_{-15k (- 0.00%)}	_359,183k	_359,238k
_{Parse Time}	_{4.17s (± 0.20%)}	_{4.20s (± 0.66%)}	_{+0.03s (+ 0.68%)}	_4.16s	_4.23s
_{Bind Time}	_{1.21s (± 0.43%)}	_{1.22s (± 0.52%)}	_{+0.01s (+ 0.55%)}	_1.21s	_1.23s
_{Check Time}	_{9.41s (± 0.30%)}	_{9.43s (± 0.52%)}	_{+0.02s (+ 0.16%)}	_9.35s	_9.48s
_{Emit Time}	_{8.06s (± 0.64%)}	_{8.09s (± 1.07%)}	_{+0.03s (+ 0.31%)}	_8.01s	_8.25s
_{Total Time}	_{22.86s (± 0.35%)}	_{22.93s (± 0.41%)}	_{+0.07s (+ 0.30%)}	_22.78s	_23.03s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,269k (± 0.05%)}	_{194,227k (± 0.03%)}	_{-43k (- 0.02%)}	_194,155k	_194,340k
_{Parse Time}	_{1.80s (± 0.23%)}	_{1.80s (± 0.58%)}	_{+0.01s (+ 0.37%)}	_1.79s	_1.82s
_{Bind Time}	_{0.84s (± 0.97%)}	_{0.85s (± 0.89%)}	_{+0.01s (+ 0.59%)}	_0.84s	_0.86s
_{Check Time}	_{10.37s (± 0.31%)}	_{10.40s (± 0.77%)}	_{+0.03s (+ 0.29%)}	_10.27s	_10.47s
_{Emit Time}	_{3.06s (± 0.60%)}	_{3.04s (± 0.90%)}	_{-0.01s (- 0.44%)}	_2.99s	_3.06s
_{Total Time}	_{16.07s (± 0.24%)}	_{16.10s (± 0.69%)}	_{+0.04s (+ 0.22%)}	_15.90s	_16.19s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,274k (± 0.02%)}	_{343,264k (± 0.01%)}	_{-10k (- 0.00%)}	_343,218k	_343,316k
_{Parse Time}	_{3.17s (± 1.03%)}	_{3.17s (± 1.34%)}	_{+0.00s (+ 0.05%)}	_3.12s	_3.23s
_{Bind Time}	_{1.11s (± 0.89%)}	_{1.12s (± 0.67%)}	_{+0.01s (+ 0.90%)}	_1.11s	_1.13s
_{Check Time}	_{7.73s (± 0.25%)}	_{7.73s (± 0.29%)}	_{+0.01s (+ 0.09%)}	_7.71s	_7.77s
_{Emit Time}	_{4.53s (± 0.95%)}	_{4.55s (± 0.82%)}	_{+0.02s (+ 0.52%)}	_4.52s	_4.62s
_{Total Time}	_{16.53s (± 0.40%)}	_{16.57s (± 0.39%)}	_{+0.04s (+ 0.26%)}	_16.47s	_16.64s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,756k (± 0.00%)}	_{299,763k (± 0.00%)}	_{+8k (+ 0.00%)}	_299,750k	_299,779k
_{Parse Time}	_{2.48s (± 1.50%)}	_{2.48s (± 1.38%)}	_{+0.01s (+ 0.27%)}	_2.43s	_2.52s
_{Bind Time}	_{1.25s (± 0.33%)}	_{1.26s (± 0.32%)}	_{+0.01s (+ 0.53%)}	_1.25s	_1.26s
_{Check Time}	_{7.20s (± 0.38%)}	_{7.17s (± 0.18%)}	_{-0.02s (- 0.35%)}	_7.15s	_7.18s
_{Emit Time}	_{4.22s (± 0.49%)}	_{4.24s (± 0.62%)}	_{+0.02s (+ 0.55%)}	_4.20s	_4.27s
_{Total Time}	_{15.14s (± 0.37%)}	_{15.15s (± 0.34%)}	_{+0.01s (+ 0.06%)}	_15.08s	_15.21s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,178k (± 0.02%)}	_{476,168k (± 0.01%)}	_{-11k (- 0.00%)}	_476,096k	_476,248k
_{Parse Time}	_{3.71s (± 0.36%)}	_{3.72s (± 0.29%)}	_{+0.01s (+ 0.22%)}	_3.71s	_3.74s
_{Bind Time}	_{1.02s (± 0.00%)}	_{1.02s (± 0.40%)}	_{+0.00s (+ 0.16%)}	_1.02s	_1.03s
_{Check Time}	_{18.11s (± 0.30%)}	_{18.15s (± 0.26%)}	_{+0.03s (+ 0.19%)}	_18.10s	_18.23s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.84s (± 0.27%)}	_{22.89s (± 0.22%)}	_{+0.04s (+ 0.18%)}	_22.83s	_22.98s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,232k (± 0.01%)}	_{546,320k (± 0.02%)}	_{+88k (+ 0.02%)}	_546,226k	_546,436k
_{Parse Time}	_{4.76s (± 0.29%)}	_{4.76s (± 0.17%)}	_{0.00s ( 0.00%)}	_4.75s	_4.77s
_{Bind Time}	_{1.80s (± 3.60%)}	_{1.75s (± 5.62%)}	_{-0.05s (- 2.68%)}	_1.66s	_1.85s
_{Check Time}	_{2.98s (± 1.15%)}	_{3.08s (± 3.16%)}	_{+0.10s (+ 3.47%)}	_2.98s	_3.18s
_{Emit Time}	_{0.09s (± 5.76%)}	_{0.10s (± 5.76%)}	_{+0.00s (+ 0.00%)}	_0.09s	_0.10s
_{Total Time}	_{9.64s (± 0.42%)}	_{9.70s (± 0.13%)}	_{+0.05s (+ 0.57%)}	_9.67s	_9.70s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,832k (± 0.01%)}	_{352,848k (± 0.01%)}	_{+16k (+ 0.00%)}	_352,814k	_352,913k
_{Parse Time}	_{4.22s (± 0.79%)}	_{4.24s (± 0.64%)}	_{+0.02s (+ 0.43%)}	_4.21s	_4.29s
_{Bind Time}	_{1.28s (± 0.49%)}	_{1.28s (± 0.32%)}	_{+0.00s (+ 0.13%)}	_1.28s	_1.29s
_{Check Time}	_{9.70s (± 0.23%)}	_{9.70s (± 0.52%)}	_{+0.00s (+ 0.03%)}	_9.63s	_9.77s
_{Emit Time}	_{8.40s (± 0.73%)}	_{8.42s (± 0.51%)}	_{+0.02s (+ 0.20%)}	_8.35s	_8.46s
_{Total Time}	_{23.61s (± 0.17%)}	_{23.64s (± 0.26%)}	_{+0.03s (+ 0.14%)}	_23.58s	_23.72s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{189,203k (± 0.08%)}	_{189,714k (± 0.66%)}	_{+511k (+ 0.27%)}	_189,031k	_192,273k
_{Parse Time}	_{1.85s (± 0.76%)}	_{1.84s (± 0.72%)}	_{-0.01s (- 0.45%)}	_1.83s	_1.86s
_{Bind Time}	_{0.86s (± 1.20%)}	_{0.87s (± 1.21%)}	_{+0.00s (+ 0.19%)}	_0.85s	_0.88s
_{Check Time}	_{10.46s (± 0.42%)}	_{10.44s (± 0.36%)}	_{-0.03s (- 0.25%)}	_10.38s	_10.48s
_{Emit Time}	_{3.40s (± 4.99%)}	_{3.36s (± 4.41%)}	_{-0.04s (- 1.13%)}	_3.17s	_3.48s
_{Total Time}	_{16.58s (± 1.00%)}	_{16.50s (± 0.93%)}	_{-0.07s (- 0.45%)}	_16.27s	_16.63s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{338,025k (± 0.00%)}	_{338,032k (± 0.00%)}	_{+8k (+ 0.00%)}	_338,017k	_338,046k
_{Parse Time}	_{3.24s (± 0.94%)}	_{3.23s (± 0.84%)}	_{-0.01s (- 0.26%)}	_3.19s	_3.26s
_{Bind Time}	_{1.11s (± 0.47%)}	_{1.11s (± 0.68%)}	_{+0.00s (+ 0.45%)}	_1.10s	_1.12s
_{Check Time}	_{8.04s (± 0.29%)}	_{8.08s (± 0.30%)}	_{+0.04s (+ 0.54%)}	_8.05s	_8.11s
_{Emit Time}	_{4.76s (± 0.59%)}	_{4.77s (± 0.50%)}	_{+0.01s (+ 0.25%)}	_4.73s	_4.80s
_{Total Time}	_{17.15s (± 0.36%)}	_{17.20s (± 0.23%)}	_{+0.05s (+ 0.29%)}	_17.14s	_17.26s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,583k (± 0.01%)}	_{294,593k (± 0.01%)}	_{+10k (+ 0.00%)}	_294,574k	_294,614k
_{Parse Time}	_{2.74s (± 0.27%)}	_{2.76s (± 0.37%)}	_{+0.01s (+ 0.55%)}	_2.74s	_2.77s
_{Bind Time}	_{1.10s (± 1.21%)}	_{1.11s (± 1.05%)}	_{+0.01s (+ 0.91%)}	_1.09s	_1.12s
_{Check Time}	_{7.52s (± 0.58%)}	_{7.53s (± 0.59%)}	_{+0.02s (+ 0.24%)}	_7.48s	_7.60s
_{Emit Time}	_{4.62s (± 0.71%)}	_{4.63s (± 0.83%)}	_{+0.01s (+ 0.22%)}	_4.59s	_4.69s
_{Total Time}	_{15.98s (± 0.51%)}	_{16.03s (± 0.35%)}	_{+0.05s (+ 0.33%)}	_15.94s	_16.10s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,559k (± 0.01%)}	_{471,609k (± 0.00%)}	_{+50k (+ 0.01%)}	_471,592k	_471,624k
_{Parse Time}	_{3.93s (± 0.67%)}	_{3.96s (± 0.77%)}	_{+0.03s (+ 0.76%)}	_3.93s	_4.01s
_{Bind Time}	_{1.04s (± 0.94%)}	_{1.05s (± 0.78%)}	_{+0.00s (+ 0.48%)}	_1.04s	_1.06s
_{Check Time}	_{19.00s (± 0.33%)}	_{19.25s (± 0.72%)}	_{+0.25s (+ 1.32%)}	_19.06s	_19.41s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{23.97s (± 0.34%)}	_{24.26s (± 0.57%)}	_{+0.29s (+ 1.20%)}	_24.09s	_24.44s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{534,470k (± 0.01%)}	_{534,475k (± 0.01%)}	_{+5k (+ 0.00%)}	_534,428k	_534,549k
_{Parse Time}	_{5.15s (± 1.24%)}	_{5.19s (± 0.79%)}	_{+0.04s (+ 0.81%)}	_5.14s	_5.23s
_{Bind Time}	_{1.72s (± 0.49%)}	_{1.73s (± 0.48%)}	_{+0.01s (+ 0.58%)}	_1.72s	_1.74s
_{Check Time}	_{3.09s (± 0.88%)}	_{3.10s (± 0.67%)}	_{+0.00s (+ 0.05%)}	_3.07s	_3.12s
_{Emit Time}	_{0.10s (± 0.00%)}	_{0.10s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.10s	_0.10s
_{Total Time}	_{10.06s (± 0.80%)}	_{10.11s (± 0.59%)}	_{+0.05s (+ 0.55%)}	_10.01s	_10.17s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₄₀	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..50640

_Metric	_main	₅₀₆₄₀	_Delta	_Best	_Worst
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,531ms (± 1.10%)}	_{2,505ms (± 1.77%)}	_{-27ms (- 1.05%)}	_2,465ms	_2,579ms
_{Req 2 - geterr}	_{5,517ms (± 0.63%)}	_{5,512ms (± 0.45%)}	_{-5ms (- 0.09%)}	_5,488ms	_5,550ms
_{Req 3 - references}	_{368ms (± 1.18%)}	_{368ms (± 1.21%)}	_{-1ms (- 0.23%)}	_364ms	_375ms
_{Req 4 - navto}	_{285ms (± 0.26%)}	_{285ms (± 1.36%)}	_{-0ms (- 0.12%)}	_277ms	_288ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{66ms (± 3.11%)}	_{65ms (± 1.79%)}	_{-1ms (- 1.76%)}	_63ms	_66ms
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,707ms (± 1.14%)}	_{2,745ms (± 1.26%)}	_{+37ms (+ 1.38%)}	_2,699ms	_2,786ms
_{Req 2 - geterr}	_{4,057ms (± 0.65%)}	_{4,052ms (± 0.70%)}	_{-5ms (- 0.12%)}	_4,023ms	_4,095ms
_{Req 3 - references}	_{370ms (± 0.65%)}	_{368ms (± 0.64%)}	_{-2ms (- 0.45%)}	_365ms	_371ms
_{Req 4 - navto}	_{299ms (± 1.49%)}	_{299ms (± 0.33%)}	_{-0ms (- 0.06%)}	_297ms	_300ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{79ms (± 8.12%)}	_{83ms (± 1.46%)}	_{+4ms (+ 4.42%)}	_81ms	_84ms
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,507ms (± 0.52%)}	_{3,531ms (± 0.50%)}	_{+24ms (+ 0.68%)}	_3,498ms	_3,549ms
_{Req 2 - geterr}	_{1,426ms (± 0.89%)}	_{1,421ms (± 0.89%)}	_{-5ms (- 0.34%)}	_1,409ms	_1,443ms
_{Req 3 - references}	_{105ms (± 1.90%)}	_{104ms (± 1.66%)}	_{-1ms (- 1.11%)}	_101ms	_106ms
_{Req 4 - navto}	_{358ms (± 0.63%)}	_{359ms (± 0.82%)}	_{+1ms (+ 0.28%)}	_356ms	_364ms
_{Req 5 - completionInfo count}	_{3,171 (± 0.00%)}	_{3,171 (± 0.00%)}	_{0 ( 0.00%)}	_3,171	_3,171
_{Req 5 - completionInfo}	_{470ms (± 0.67%)}	_{469ms (± 1.60%)}	_{-1ms (- 0.11%)}	_459ms	_480ms
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,770ms (± 1.04%)}	_{2,778ms (± 0.47%)}	_{+9ms (+ 0.31%)}	_2,765ms	_2,799ms
_{Req 2 - geterr}	_{5,852ms (± 0.45%)}	_{5,899ms (± 0.28%)}	_{+47ms (+ 0.79%)}	_5,870ms	_5,918ms
_{Req 3 - references}	_{374ms (± 1.02%)}	_{379ms (± 1.37%)}	_{+5ms (+ 1.25%)}	_373ms	_386ms
_{Req 4 - navto}	_{278ms (± 0.71%)}	_{279ms (± 0.42%)}	_{+2ms (+ 0.60%)}	_278ms	_281ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{77ms (± 8.12%)}	_{73ms (± 4.62%)}	_{🟩-4ms (- 4.79%)}	_69ms	_77ms
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,934ms (± 0.52%)}	_{2,962ms (± 0.92%)}	_{+28ms (+ 0.95%)}	_2,932ms	_3,004ms
_{Req 2 - geterr}	_{4,403ms (± 0.38%)}	_{4,394ms (± 0.56%)}	_{-9ms (- 0.21%)}	_4,365ms	_4,423ms
_{Req 3 - references}	_{380ms (± 1.02%)}	_{378ms (± 0.41%)}	_{-2ms (- 0.57%)}	_376ms	_380ms
_{Req 4 - navto}	_{289ms (± 0.72%)}	_{288ms (± 0.84%)}	_{-1ms (- 0.29%)}	_285ms	_291ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{71ms (± 0.72%)}	_{72ms (± 0.00%)}	_{+1ms (+ 0.93%)}	_72ms	_72ms
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,631ms (± 0.41%)}	_{3,628ms (± 0.25%)}	_{-3ms (- 0.07%)}	_3,617ms	_3,641ms
_{Req 2 - geterr}	_{1,571ms (± 1.09%)}	_{1,566ms (± 1.52%)}	_{-4ms (- 0.28%)}	_1,525ms	_1,586ms
_{Req 3 - references}	_{110ms (± 2.15%)}	_{112ms (± 1.19%)}	_{+2ms (+ 1.67%)}	_110ms	_113ms
_{Req 4 - navto}	_{342ms (± 1.04%)}	_{342ms (± 1.09%)}	_{0ms ( 0.00%)}	_337ms	_346ms
_{Req 5 - completionInfo count}	_{3,171 (± 0.00%)}	_{3,171 (± 0.00%)}	_{0 ( 0.00%)}	_3,171	_3,171
_{Req 5 - completionInfo}	_{478ms (± 0.79%)}	_{477ms (± 0.71%)}	_{-0ms (- 0.07%)}	_474ms	_482ms
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,906ms (± 0.35%)}	_{2,917ms (± 0.23%)}	_{+11ms (+ 0.38%)}	_2,907ms	_2,926ms
_{Req 2 - geterr}	_{6,264ms (± 0.51%)}	_{6,308ms (± 1.16%)}	_{+43ms (+ 0.69%)}	_6,218ms	_6,433ms
_{Req 3 - references}	_{388ms (± 0.70%)}	_{393ms (± 1.02%)}	_{+5ms (+ 1.29%)}	_389ms	_401ms
_{Req 4 - navto}	_{282ms (± 1.73%)}	_{283ms (± 1.32%)}	_{+1ms (+ 0.30%)}	_278ms	_289ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{85ms (± 6.38%)}	_{88ms (± 8.76%)}	_{+4ms (+ 4.34%)}	_73ms	_93ms
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,074ms (± 0.40%)}	_{3,084ms (± 0.42%)}	_{+10ms (+ 0.31%)}	_3,065ms	_3,097ms
_{Req 2 - geterr}	_{4,694ms (± 0.37%)}	_{4,721ms (± 0.26%)}	_{+27ms (+ 0.56%)}	_4,712ms	_4,744ms
_{Req 3 - references}	_{403ms (± 0.65%)}	_{405ms (± 1.07%)}	_{+2ms (+ 0.41%)}	_398ms	_410ms
_{Req 4 - navto}	_{293ms (± 0.91%)}	_{293ms (± 0.78%)}	_{+0ms (+ 0.11%)}	_289ms	_296ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{81ms (± 1.01%)}	_{81ms (± 0.64%)}	_{0ms ( 0.00%)}	_80ms	_81ms
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,962ms (± 0.47%)}	_{4,000ms (± 0.43%)}	_{+37ms (+ 0.94%)}	_3,973ms	_4,023ms
_{Req 2 - geterr}	_{1,524ms (± 2.03%)}	_{1,513ms (± 0.54%)}	_{-11ms (- 0.70%)}	_1,500ms	_1,522ms
_{Req 3 - references}	_{132ms (± 2.25%)}	_{132ms (± 2.85%)}	_{-0ms (- 0.13%)}	_127ms	_137ms
_{Req 4 - navto}	_{374ms (± 0.57%)}	_{375ms (± 0.29%)}	_{+1ms (+ 0.22%)}	_374ms	_377ms
_{Req 5 - completionInfo count}	_{3,171 (± 0.00%)}	_{3,171 (± 0.00%)}	_{0 ( 0.00%)}	_3,171	_3,171
_{Req 5 - completionInfo}	_{505ms (± 2.35%)}	_{509ms (± 2.14%)}	_{+4ms (+ 0.83%)}	_492ms	_525ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₄₀	₆
_Baseline	_main	₆

Startup

Comparison Report - main..50640

_Metric	_main	₅₀₆₄₀	_Delta	_Best	_Worst
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.62ms (± 0.19%)}	_{142.52ms (± 0.18%)}	_{-0.10ms (- 0.07%)}	_141.55ms	_146.56ms
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.34ms (± 0.18%)}	_{229.15ms (± 0.50%)}	_{+2.81ms (+ 1.24%)}	_225.18ms	_234.99ms
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{229.01ms (± 0.23%)}	_{231.56ms (± 0.40%)}	_{+2.54ms (+ 1.11%)}	_227.83ms	_242.62ms
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{209.44ms (± 0.17%)}	_{210.16ms (± 0.26%)}	_{+0.72ms (+ 0.34%)}	_208.62ms	_216.53ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₀₆₄₀	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

jakebailey · 2023-01-27T06:31:59Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt

typescript-bot · 2023-01-27T06:32:03Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 8f978fd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-27T06:32:03Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 8f978fd. You can monitor the build here.

typescript-bot · 2023-01-27T06:32:03Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 8f978fd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-27T06:32:03Z

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 8f978fd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-27T06:32:03Z

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 8f978fd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-27T06:32:03Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 8f978fd. You can monitor the build here.

typescript-bot · 2023-01-27T06:42:30Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/50640/merge:

Everything looks good!

typescript-bot · 2023-01-27T06:44:59Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/50640/merge:

Everything looks good!

typescript-bot · 2023-01-27T06:46:32Z

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-01-27T08:04:08Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/50640/merge:

Everything looks good!

typescript-bot · 2023-01-27T08:19:05Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/50640/merge:

Something interesting changed - please have a look.

Details

palantir/blueprint

⚠️ Note that built also had errors ⚠️

Req #19430 - completionEntryDetails
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77733:33)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68256:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68595:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68481:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68438:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68256:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68595:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68481:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68438:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68256:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68595:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68481:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68438:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68256:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68595:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68481:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68438:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68256:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68595:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68481:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68438:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68256:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68595:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68481:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68438:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68256:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68595:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68481:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68438:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68256:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68595:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68481:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68438:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72259:162)

Req #19430 - completionEntryDetails
    at getContextualTypeForArgument (/typescript-50640/built/local/tsserver.js:70378:40)
    at getContextualType2 (/typescript-50640/built/local/tsserver.js:70822:16)
    at getApparentTypeOfContextualType (/typescript-50640/built/local/tsserver.js:70758:120)
    at getContextualType2 (/typescript-50640/built/local/tsserver.js:70837:22)
    at getApparentTypeOfContextualType (/typescript-50640/built/local/tsserver.js:70758:120)
    at getContextualSignature (/typescript-50640/built/local/tsserver.js:71125:18)
    at getNarrowedTypeOfSymbol (/typescript-50640/built/local/tsserver.js:69574:39)
    at checkIdentifier (/typescript-50640/built/local/tsserver.js:69666:16)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77766:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at checkPropertyAccessExpression (/typescript-50640/built/local/tsserver.js:72280:162)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77800:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at getEffectsSignature (/typescript-50640/built/local/tsserver.js:68277:22)
    at getTypeAtFlowCall (/typescript-50640/built/local/tsserver.js:68616:25)
    at getTypeAtFlowNode (/typescript-50640/built/local/tsserver.js:68502:18)
    at getFlowTypeOfReference (/typescript-50640/built/local/tsserver.js:68459:45)
    at checkIdentifier (/typescript-50640/built/local/tsserver.js:69708:22)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77766:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at checkPropertyAccessExpression (/typescript-50640/built/local/tsserver.js:72280:162)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77800:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at getEffectsSignature (/typescript-50640/built/local/tsserver.js:68277:22)
    at getTypeAtFlowCall (/typescript-50640/built/local/tsserver.js:68616:25)
    at getTypeAtFlowNode (/typescript-50640/built/local/tsserver.js:68502:18)
    at getFlowTypeOfReference (/typescript-50640/built/local/tsserver.js:68459:45)
    at checkIdentifier (/typescript-50640/built/local/tsserver.js:69708:22)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77766:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at checkPropertyAccessExpression (/typescript-50640/built/local/tsserver.js:72280:162)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77800:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at getEffectsSignature (/typescript-50640/built/local/tsserver.js:68277:22)
    at getTypeAtFlowCall (/typescript-50640/built/local/tsserver.js:68616:25)
    at getTypeAtFlowNode (/typescript-50640/built/local/tsserver.js:68502:18)
    at getFlowTypeOfReference (/typescript-50640/built/local/tsserver.js:68459:45)
    at checkIdentifier (/typescript-50640/built/local/tsserver.js:69708:22)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77766:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at checkPropertyAccessExpression (/typescript-50640/built/local/tsserver.js:72280:162)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77800:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at getEffectsSignature (/typescript-50640/built/local/tsserver.js:68277:22)
    at getTypeAtFlowCall (/typescript-50640/built/local/tsserver.js:68616:25)
    at getTypeAtFlowNode (/typescript-50640/built/local/tsserver.js:68502:18)
    at getFlowTypeOfReference (/typescript-50640/built/local/tsserver.js:68459:45)
    at checkIdentifier (/typescript-50640/built/local/tsserver.js:69708:22)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77766:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at checkPropertyAccessExpression (/typescript-50640/built/local/tsserver.js:72280:162)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77800:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at getEffectsSignature (/typescript-50640/built/local/tsserver.js:68277:22)
    at getTypeAtFlowCall (/typescript-50640/built/local/tsserver.js:68616:25)
    at getTypeAtFlowNode (/typescript-50640/built/local/tsserver.js:68502:18)
    at getFlowTypeOfReference (/typescript-50640/built/local/tsserver.js:68459:45)
    at checkIdentifier (/typescript-50640/built/local/tsserver.js:69708:22)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77766:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at checkPropertyAccessExpression (/typescript-50640/built/local/tsserver.js:72280:162)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77800:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at getEffectsSignature (/typescript-50640/built/local/tsserver.js:68277:22)
    at getTypeAtFlowCall (/typescript-50640/built/local/tsserver.js:68616:25)
    at getTypeAtFlowNode (/typescript-50640/built/local/tsserver.js:68502:18)
    at getFlowTypeOfReference (/typescript-50640/built/local/tsserver.js:68459:45)
    at checkIdentifier (/typescript-50640/built/local/tsserver.js:69708:22)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77766:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at checkPropertyAccessExpression (/typescript-50640/built/local/tsserver.js:72280:162)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77800:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at getEffectsSignature (/typescript-50640/built/local/tsserver.js:68277:22)
    at getTypeAtFlowCall (/typescript-50640/built/local/tsserver.js:68616:25)
    at getTypeAtFlowNode (/typescript-50640/built/local/tsserver.js:68502:18)
    at getFlowTypeOfReference (/typescript-50640/built/local/tsserver.js:68459:45)
    at checkIdentifier (/typescript-50640/built/local/tsserver.js:69708:22)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77766:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at checkPropertyAccessExpression (/typescript-50640/built/local/tsserver.js:72280:162)
    at checkExpressionWorker (/typescript-50640/built/local/tsserver.js:77800:16)
    at checkExpression (/typescript-50640/built/local/tsserver.js:77720:32)
    at checkNonNullExpression (/typescript-50640/built/local/tsserver.js:72201:29)
    at getEffectsSignature (/typescript-50640/built/local/tsserver.js:68277:22)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

{"seq":19427,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":278158,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":19428,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":278158,"entryNames":["_"]}}
{"seq":19429,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":280850,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":19430,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":280850,"entryNames":["_"]}}

Repro Steps

git clone https://github.com/palantir/blueprint --recurse-submodules
In dir blueprint, run git reset --hard f3be31b619cde60772150ce5e08972f9e6de5138
In dir blueprint, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

ahejlsberg

This is superceded by the more general #53192.

Experiment short-circuiting of union distribution

cd31843

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 5, 2022

sandersn added the Experiment A fork with an experimental idea which might not make it into master label Sep 21, 2022

sandersn requested review from ahejlsberg and jakebailey September 21, 2022 23:08

sandersn assigned ahejlsberg Sep 21, 2022

sandersn removed the Experiment A fork with an experimental idea which might not make it into master label Sep 21, 2022

Merge branch 'main' into short-circuiting-of-union-type

8f978fd

Andarist mentioned this pull request Mar 10, 2023

Fast path for negative case when relating to unions of primtives #53192

Merged

ahejlsberg reviewed Mar 14, 2023

View reviewed changes

ahejlsberg removed their assignment Mar 14, 2023

ahejlsberg added Declined The issue was declined as something which matches the TypeScript vision and removed For Backlog Bug PRs that fix a backlog bug labels Mar 14, 2023

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Mar 14, 2023

sandersn closed this Mar 14, 2023

Experiment short-circuiting of union distribution #50640

Experiment short-circuiting of union distribution #50640

Conversation

Zzzen commented Sep 5, 2022 • edited Loading

jakebailey commented Sep 9, 2022

typescript-bot commented Sep 9, 2022 • edited Loading

typescript-bot commented Sep 9, 2022 • edited Loading

typescript-bot commented Sep 9, 2022 • edited Loading

typescript-bot commented Sep 9, 2022 • edited Loading

typescript-bot commented Sep 9, 2022 • edited Loading

typescript-bot commented Sep 9, 2022

typescript-bot commented Sep 9, 2022

typescript-bot commented Sep 9, 2022

jakebailey commented Sep 9, 2022

typescript-bot commented Sep 14, 2022

sandersn commented Sep 21, 2022

typescript-bot commented Sep 21, 2022 • edited Loading

typescript-bot commented Sep 22, 2022

jakebailey commented Sep 22, 2022

jakebailey commented Jan 27, 2023 • edited Loading

typescript-bot commented Jan 27, 2023 • edited Loading

typescript-bot commented Jan 27, 2023

Compiler

TSServer

Startup

jakebailey commented Jan 27, 2023

typescript-bot commented Jan 27, 2023 • edited Loading

typescript-bot commented Jan 27, 2023 • edited Loading

typescript-bot commented Jan 27, 2023 • edited Loading

typescript-bot commented Jan 27, 2023 • edited Loading

typescript-bot commented Jan 27, 2023 • edited Loading

typescript-bot commented Jan 27, 2023 • edited Loading

typescript-bot commented Jan 27, 2023

typescript-bot commented Jan 27, 2023

typescript-bot commented Jan 27, 2023

typescript-bot commented Jan 27, 2023

typescript-bot commented Jan 27, 2023

palantir/blueprint

Last few requests

Repro Steps

ahejlsberg left a comment

Choose a reason for hiding this comment

Zzzen commented Sep 5, 2022 •

edited

Loading

typescript-bot commented Sep 9, 2022 •

edited

Loading

typescript-bot commented Sep 9, 2022 •

edited

Loading

typescript-bot commented Sep 9, 2022 •

edited

Loading

typescript-bot commented Sep 9, 2022 •

edited

Loading

typescript-bot commented Sep 9, 2022 •

edited

Loading

typescript-bot commented Sep 21, 2022 •

edited

Loading

jakebailey commented Jan 27, 2023 •

edited

Loading

typescript-bot commented Jan 27, 2023 •

edited

Loading

typescript-bot commented Jan 27, 2023 •

edited

Loading

typescript-bot commented Jan 27, 2023 •

edited

Loading

typescript-bot commented Jan 27, 2023 •

edited

Loading

typescript-bot commented Jan 27, 2023 •

edited

Loading

typescript-bot commented Jan 27, 2023 •

edited

Loading

typescript-bot commented Jan 27, 2023 •

edited

Loading