This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add version to all telemetry events, and properly trigger start-up telemetry #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Mar 22, 2018
src/nodeDebugAdapter.ts
Outdated
| return super.configurationDone(); | ||
| await super.configurationDone(); | ||
|
|
||
| this.events.emit(ChromeDebugSession.FinishedStartingUpEventName); |
There was a problem hiding this comment.
Does this have to go after the super call? Would rather leave the super call as the last line unless there's a reason for it.
src/nodeDebugAdapter.ts
Outdated
| if (!this.chrome) { | ||
| // It's possible to get this request after we've detached, see #21973 | ||
| return super.configurationDone(); | ||
| await super.configurationDone(); | ||
| return; |
There was a problem hiding this comment.
This is equivalent to return super.configurationDone(), you could leave it that way for simplicity
|
Lots of CI failures? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We report the node version and Versions.DebugAdapter as a common telemetry property
We also trigger ChromeDebugSession.FinishedStartingUpEventName to properly mark the end of startup and trigger the end of the report-start-up-timings telemetry event