Skip to content

Allow authentication for github enterprise #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicholas-l
Copy link
Contributor

@nicholas-l nicholas-l commented Oct 26, 2021

This adds a condition for github enterpise session when there is no session for github.com.
I believe this fixes #3056

@ghost
Copy link

ghost commented Oct 28, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test whether this fixes enterprise, but I did check that it doesn't break github accounts and fixed an issue with that.

@alexr00 alexr00 added this to the October 2021 milestone Oct 28, 2021
@alexr00
Copy link
Member

alexr00 commented Oct 28, 2021

@nicholas-l once you sign the license agreement as requested by the bot I will merge this PR.

@alexr00 alexr00 self-assigned this Oct 28, 2021
@nicholas-l
Copy link
Contributor Author

I have signed the CLA. Also thanks for adding the try-catch, I didn't know it would throw 😃

@alexr00 alexr00 merged commit 1247940 into microsoft:main Oct 28, 2021
@nicholas-l nicholas-l deleted the allow-authentication-for-github-enterprise branch November 5, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't connect to GHE by 0.31.1 when upgrade vscode from 1.61.1 to v1.61.2
2 participants