`onDidExecuteTerminalCommand` does not fire events for hidden terminal

[karrtikr]

Does this issue occur when all extensions are disabled?: Yes/No

For proposed API: #145234

Version: 1.85.0-insider (user setup)
OS: Windows_NT x64 10.0.22518

Steps to Reproduce:

1. Create a hidden terminal using hideFromUser to true
2. Send text to terminal, for eg. "echo hello"
3. Watch no events are fired

Same is not the case if hideFromUser is set to false.

cc/ @Tyriar

[karrtikr]

@Tyriar @meganrogge Any idea where the issue could be here? We require this to start leveraging #145234.

[Tyriar]

This is by design according to this:

vscode/src/vs/platform/terminal/node/terminalEnvironment.ts

Lines 120 to 122 in 08159ae

	if (!options.shellIntegration.enabled || !shellLaunchConfig.executable || (shellLaunchConfig.isFeatureTerminal && !shellLaunchConfig.forceShellIntegration) || shellLaunchConfig.hideFromUser || shellLaunchConfig.ignoreShellIntegration || useWinpty) {
	return undefined;
	}

We tweaked the condition in #206543 to work properly on remotes, and tried to force shell integration for debug terminals here:

vscode/src/vs/workbench/api/node/extHostDebugService.ts

Lines 111 to 113 in 08159ae

	// Since debug termnials are REPLs, we want shell integration to be enabled.
	// Ignore isFeatureTerminal when evaluating shell integration enablement.
	forceShellIntegration: true,

I don't see an issue with changing hidden terminals from having shell integration, we just need to watch the incoming issues for problems.

[Tyriar]

If we have shell integration in hidden terminals is conflicts with #197187 (comment) but I think the thinking was changed in #194819 (comment)?

If you don't want env collections you must pass strictEnv, which means you need to provide the entire environment.