Skip to content

Display line numbers in front of search results (#190742) #195452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Display line numbers in front of search results (#190742) #195452

merged 1 commit into from
Nov 1, 2023

Conversation

elseifthen
Copy link
Contributor

This commit puts the line numbers you get when search.showLineNumbers is set to true and you search your workspace using the Edit > Find in Files function in front of each search hit (previously, they were at the end of the line), similar to how search hits are displayed in Eclipse. This has been requested in #190742.

@andreamah andreamah added this to the November 2023 milestone Oct 23, 2023
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@andreamah andreamah merged commit 5619bdd into microsoft:main Nov 1, 2023
@elseifthen elseifthen deleted the linenumbers_in_front branch November 2, 2023 07:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants