Resize terminal: "slice bounds out of range" in `util/progress/progressui.wrapHeight`

[mhansen]

Hi there, I was running a long build, and I was resizing my terminal in tmux. It got pretty small, maybe 1 line high, maybe less (I had a few vertically stacked frames and I was rearranging them - at the midpoint they got pretty short), anyway, my build was aborted with a panic in the progress UI library.

I gotta admit I laughed a bit, it's the first time that resizing my terminal has aborted my build :-)

panic: runtime error: slice bounds out of range

goroutine 8 [running]:
github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui.wrapHeight(0xc000678800, 0x3c, 0x40, 0xffffffffffffffff, 0x2, 0xc0005086f0, 0x1)
        /go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:554 +0x4f3
github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui.setupTerminals(0xc000678800, 0x3c, 0x40, 0x1, 0x0, 0x1, 0x2b55940, 0x0)
        /go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:433 +0x2ee
github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui.(*display).print(0xc000177e40, 0xbfa667cb4ee3f5c8, 0x2a9e25e, 0x2b55940, 0xc000678800, 0x3c, 0x40, 0x18, 0x10, 0xcc, ...)
        /go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:441 +0x76
github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui.DisplaySolveStatus(0x210a5e0, 0xc0002a5100, 0x0, 0x0, 0x2124780, 0xc0003d6410, 0x20d8600, 0xc00000e010, 0xc00008eae0, 0x0, ...)
        /go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:76 +0x62e
github.com/docker/buildx/util/progress.NewPrinter.func1(0xc00000e010, 0x1f05d64, 0x4, 0x210a5e0, 0xc0002a5100, 0xc00008eae0, 0xc000312920, 0xc00008eb40)
        /go/src/github.com/docker/buildx/util/progress/printer.go:52 +0x9c
created by github.com/docker/buildx/util/progress.NewPrinter
        /go/src/github.com/docker/buildx/util/progress/printer.go:46 +0x15c

[thaJeztah]

What version of Docker are you running? (can you post docker version output)?

[mhansen]

Oh, sorry for omitting that. I'm on a mac.

$ docker version
Client: Docker Engine - Community
 Version:           19.03.8
 API version:       1.40
 Go version:        go1.12.17
 Git commit:        afacb8b
 Built:             Wed Mar 11 01:21:11 2020
 OS/Arch:           darwin/amd64
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          19.03.8
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.17
  Git commit:       afacb8b
  Built:            Wed Mar 11 01:29:16 2020
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.2.13
  GitCommit:        7ad184331fa3e55e52b890ea95e65ba581ae3429
 runc:
  Version:          1.0.0-rc10
  GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

[thaJeztah]

Thanks! That helps finding the right line in the code (and to check if there's possibly a fix on "master" already)

[mhansen]

Thank you!

…

On Wed, 13 May 2020 at 03:50, Akihiro Suda ***@***.***> wrote: Closed #1479 <#1479> via #1486 <#1486>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1479 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZYOJNETOMFJYHFT2UQJLRRGD4PANCNFSM4M5ZNOUQ> .

[johnbizokk]

Hello! Has the fix been already incorporated in the latest Docker CE release? Suddenly, I had faced the problem in the latest Docker Desktop for Windows. I am receiving the following error, if the terminal height small enough:

panic: runtime error: slice bounds out of range [1:0]

goroutine 21 [running]:
github.com/docker/cli/vendor/github.com/moby/buildkit/util/progress/progressui.wrapHeight(0x0, 0x0, 0x0, 0xffffffffffffffff, 0xd00100051bffff, 0x4b0b760, 0x0)
        /go/src/github.com/docker/cli/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:554 +0x4f9
github.com/docker/cli/vendor/github.com/moby/buildkit/util/progress/progressui.setupTerminals(0x0, 0x0, 0x0, 0x1, 0xc0006ac000, 0xc000690000, 0x40fa48, 0x19e70f0)
        /go/src/github.com/docker/cli/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:433 +0x2f2
github.com/docker/cli/vendor/github.com/moby/buildkit/util/progress/progressui.(*display).print(0xc00068dda8, 0xbfcebd47cdb33d20, 0x2dc7949, 0x302a680, 0x0, 0x0, 0x0, 0x1, 0x0, 0xb9, ..
.)
        /go/src/github.com/docker/cli/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:441 +0x7d
github.com/docker/cli/vendor/github.com/moby/buildkit/util/progress/progressui.DisplaySolveStatus(0x217df20, 0xc000046128, 0x0, 0x0, 0x21aebc0, 0xc000048540, 0x211eee0, 0xc000006020, 0x
c0006502a0, 0x0, ...)
        /go/src/github.com/docker/cli/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:76 +0x658
github.com/docker/cli/cli/command/image.doBuild.func2.1(0xc00068df68, 0x0)
        /go/src/github.com/docker/cli/cli/command/image/build_buildkit.go:281 +0x7c
github.com/docker/cli/vendor/golang.org/x/sync/errgroup.(*Group).Go.func1(0xc00061a660, 0xc000652210)
        /go/src/github.com/docker/cli/vendor/golang.org/x/sync/errgroup/errgroup.go:57 +0x6b
created by github.com/docker/cli/vendor/golang.org/x/sync/errgroup.(*Group).Go
        /go/src/github.com/docker/cli/vendor/golang.org/x/sync/errgroup/errgroup.go:54 +0x6d

Output of docker version:

Client: Docker Engine - Community
 Version:           19.03.12
 API version:       1.40
 Go version:        go1.13.10
 Git commit:        48a66213fe
 Built:             Mon Jun 22 15:43:18 2020
 OS/Arch:           windows/amd64
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          19.03.12
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.10
  Git commit:       48a66213fe
  Built:            Mon Jun 22 15:49:27 2020
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          v1.2.13
  GitCommit:        7ad184331fa3e55e52b890ea95e65ba581ae3429
 runc:
  Version:          1.0.0-rc10
  GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

Output of docker info:

Client:
 Debug Mode: false
 Plugins:
  app: Docker Application (Docker Inc., v0.8.0)
  buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)
  mutagen: Synchronize files with Docker Desktop (Docker Inc., testing)

Server:
 Containers: XX
  Running: XX
  Paused: XX
  Stopped: XX
 Images: XXX
 Server Version: 19.03.12
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Native Overlay Diff: true
 Logging Driver: local
 Cgroup Driver: cgroupfs
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: active
  NodeID: X
  Is Manager: true
  ClusterID: XX
  Managers: 1
  Nodes: 1
  Default Address Pool: 10.0.0.0/8
  SubnetSize: 24
  Data Path Port: 4789
  Orchestration:
   Task History Retention Limit: 5
  Raft:
   Snapshot Interval: 10000
   Number of Old Snapshots to Retain: 0
   Heartbeat Tick: 1
   Election Tick: 10
  Dispatcher:
   Heartbeat Period: 5 seconds
  CA Configuration:
   Expiry Duration: 3 months
   Force Rotate: 0
  Autolock Managers: false
  Root Rotation In Progress: false
  Node Address: XX
  Manager Addresses:
   XX:XX
 Runtimes: runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 7ad184331fa3e55e52b890ea95e65ba581ae3429
 runc version: dc9208a3303feef5b3839f4323d9beb36df0a9dd
 init version: fec3683
 Security Options:
  seccomp
   Profile: default
 Kernel Version: 4.19.104-microsoft-standard
 Operating System: Docker Desktop
 OSType: linux
 Architecture: x86_64
 CPUs: XXX
 Total Memory: XX.XXGiB
 Name: docker-desktop
 ID: XX
 Docker Root Dir: /var/lib/docker
 Debug Mode: true
  File Descriptors: 57
  Goroutines: 167
  System Time: 2020-09-10T19:28:06.7714151Z
  EventsListeners: 2
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: true
 Insecure Registries:
  127.0.0.0/8
 Live Restore Enabled: false
 Product License: Community Engine

WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled

[thaJeztah]

No, I don't think this has been backported yet

[thaJeztah]

opened a backport #1680 (after that the dependency will have to be updated in docker 19.03)