fix(mongo client): do not connect if url parse error

Jessica Lord · Jessica Lord · commit cd1008409c29 · 2017-11-20T15:47:20.000-05:00
diff --git a/lib/mongo_client.js b/lib/mongo_client.js
@@ -849,7 +849,8 @@ var connect = function(self, url, options, callback) {
   }
 
   parse(url, options, function(err, object) {
-    if (err) return console.log(err);
+    // Do not attempt to connect if parsing error
+    if (err) return callback(err);
 
     // Parse the string
     var _finalOptions = createUnifiedOptions({}, object);

Original file line number	Diff line number	Diff line change
`@@ -849,7 +849,8 @@ var connect = function(self, url, options, callback) {`
`849`	`849`	`}`
`850`	`850`
`851`	`851`	`parse(url, options, function(err, object) {`
`852`		`- if (err) return console.log(err);`
	`852`	`+ // Do not attempt to connect if parsing error`
	`853`	`+ if (err) return callback(err);`
`853`	`854`
`854`	`855`	`// Parse the string`
`855`	`856`	`var _finalOptions = createUnifiedOptions({}, object);`