refactor(db)!: suppress Db events #2251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
suggested changes
Mar 6, 2020
reggi
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
I did some obvious searches for different event methods, db.on and db.emit, etc, nothing comes up. My only fear is that we may be using a method still somewhere const something = client.db(... then something.emit, but it seems that shouldn't be happening anywhere.
This looks good to me.
mbroadst
suggested changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-1709 - Stop emitting topology events from
DbNODE-2484 - Fix double close event
What changed?
The
Dbclass no longer inheritsEventEmitter, andMongoClientno longer forwards topology events toDbobjects. Some event handlers in the unit tests were updated to reflect this, and a deprecatedunifiedTopology: falsetest was removed.Are there any files to ignore?