Skip to content

feat: remove the collection save method #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

mbroadst
Copy link
Member

This method has been deprecated for quite some time, and now is being fully removed in favor of the standard CRUD operations with atomic operators.

NODE-2736

NOTE: as mentioned in the jira ticket, this is only being split out and prioritized to facilitate easier refactoring wrt retryability

@mbroadst mbroadst requested review from reggi, emadum and nbbeeken July 25, 2020 14:07
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a lint issue, but beyond that LGTM, yay deletions! 🎈

This method has been deprecated for quite some time, and now is
being fully removed in favor of the standard CRUD operations with
atomic operators.

NODE-2736
@mbroadst mbroadst force-pushed the NODE-2736/remove-save branch from e2148b2 to 43764b6 Compare July 28, 2020 11:50
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbroadst mbroadst merged commit d5bb496 into master Jul 28, 2020
@mbroadst mbroadst deleted the NODE-2736/remove-save branch July 28, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants