refactor!(NODE-3368): make name prop on error classes read-only #2879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b/node-mongodb-native into NODE-3368/4.0/error-name-readonly
nbbeeken
requested changes
Jul 2, 2021
nbbeeken
reviewed
Jul 6, 2021
Co-authored-by: Neal Beeken <[email protected]>
dariakp
requested changes
Jul 6, 2021
src/cmap/errors.ts
Outdated
| this.address = pool.address; | ||
| } | ||
|
|
||
| get name(): string { | ||
| return 'PoolClosedError'; |
There was a problem hiding this comment.
are the two renamings in this file intentional? these could potentially be breaking changes
There was a problem hiding this comment.
This was unintentional, but this did highlight another issue. The test should assert that the name prop matches the actual name of the class, but this isn't true for PoolClosedError and WaitQueueTimeoutError as both of their name props add the "Mongo" prefix. For now, I've imported both of those errors and aliased them with their "Mongo" prefix, but it's only a temporary fix to a potentially larger problem.
dariakp
reviewed
Jul 6, 2021
dariakp
approved these changes
Jul 7, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.nameproperty to ensure it is a read-only and matches the class name