Skip to content

Bug parsing numeric subdomains #46

@bitc

Description

@bitc

This gives weird behaviour:

> mkURI "https://104.155.144.4.sslip.io:443/"

The host gets chopped and half of it along with the port end up in the uriPath:

URI {
  uriScheme = Just "https",
  uriAuthority = Right (Authority {authUserInfo = Nothing, authHost = "104.155.144.4", authPort = Nothing}),
  uriPath = Just (True,".sslip.io:443" :| []),
  uriQuery = [],
  uriFragment = Nothing
}

I think it may be true that according to some RFCs there shouldn't be numbers in subdomains, but in practice these types of domains exist and work fine everywhere.

In any case, when I roundtrip the current result we get back the following, which is different than the original:

> render uri
"https://104.155.144.4/.sslip.io%3a443/"

Btw the example url I am using is a real url, part of the sslip.io service: https://104.155.144.4.sslip.io:443/

Thank you

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions