pkg-config should look for headers in include root #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since meson installs the bstring headers directly into the include dir, the pkg-config file should also point to the root include dir rather than a bstring subdir This fixes a mismatch that existed since the meson build system was introduced for this library
|
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 03830c6 |
Collaborator
Author
|
@msteinert With this fix, I think it's worth tagging a new release. It effectively makes it impossible to use the packaged library's development headers, which I encountered first hand with the macOS homebrew formula yesterday. |
Collaborator
Author
|
Also, this release might be the opportunity to flag the Autotools build system as deprecated so that we can remove it in a subsequent version! |
Collaborator
Author
|
@msteinert ...but if you're preoccupied for the foreseeable future, I'm happy to self-merge these two trivial PRs and cut a release myself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since meson installs the bstring headers directly into the include dir, the pkg-config file should also point to the root include dir rather than a bstring subdir
This fixes a mismatch that existed since the meson build system was introduced for this library