Skip to content

Conversation

@caylahamann
Copy link
Contributor

@caylahamann caylahamann commented Mar 4, 2021

Reduces the space between timeline events for whatsnew and releasenotes

closes #911

Before

Screen Shot 2021-03-04 at 2 41 56 PM

After

Screen Shot 2021-03-04 at 2 49 24 PM

@jerelmiller
Copy link
Contributor

Could we instead use 2rem? While its not a written rule right now, I've generally been using 2rem to be the space between 2 groups of content together. This seems to work pretty well site-wide. Would be good to get this into more of a formal "spacing" guide at some point 😄

@caylahamann
Copy link
Contributor Author

@jerelmiller yep! that's a good call. I'll make that update.

@caylahamann
Copy link
Contributor Author

@jerelmiller updated as well as updated the PR with the new photo :) I'll wait on feedback from mark and austin

Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming others like it, this is much better! Thank you 🙂

@jpvajda
Copy link

jpvajda commented Mar 4, 2021

LGTM!

@caylahamann caylahamann added the eng issues related to site functionality that requires engineering label Mar 4, 2021
@caylahamann
Copy link
Contributor Author

I'm going to merge this in! If mark doesn't like it we can always change it to a different value, it's a pretty small change :)

@caylahamann caylahamann merged commit 8dc340a into develop Mar 5, 2021
@caylahamann caylahamann deleted the cayla/reduce-margin-timeline branch March 5, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eng issues related to site functionality that requires engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shorten the distance between Posts on Release Notes + What’s new.

4 participants