Progress for the amount of docs migrated so far! #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
suggested changes
Oct 27, 2020
| return parseInt(cur) + acc | ||
| }, 0) | ||
|
|
||
| writeSync( vfile({ |
Contributor
There was a problem hiding this comment.
Could you make sure prettier is run on this file? It looks like this is not formatted. Thank you!
Contributor
Author
There was a problem hiding this comment.
yes definitely!
| const result = await resp.json(); | ||
|
|
||
| const totalCount = parseInt(result.docs[0].count.all); | ||
| const migratedCount = Object.values(ITEMS_PER_TYPE).reduce((acc, cur)=>{ |
Contributor
There was a problem hiding this comment.
Rather than using the ITEMS_PER_TYPE, should we pass in the files array from the first step of the migration and run a .length on that? This ITEMS_PER_TYPE does not guarantee that that exact number of docs is fetched, nor does it take into account more than one page of results. Eventually we will paginate more than a single page of results.
Thoughts?
Contributor
Author
There was a problem hiding this comment.
I like that idea! I will make that change
src/announcements/beta-banner.mdx
Outdated
|
|
||
| This experimental version doesn't contain all our content, and not everything is stable. If you're looking to read our docs, go to [docs.newrelic.com](https://docs.newrelic.com). | ||
|
|
||
| So far, we have migrated **{data.migratedCount}** out of **{data.totalCount}** docs! |
Contributor
Author
|
once I have the copy from @jpvajda , I'll make the other updates to this PR! |
jpvajda
reviewed
Oct 28, 2020
jerelmiller
approved these changes
Oct 28, 2020
kanderson250
pushed a commit
to kanderson250/docs-website
that referenced
this pull request
Aug 29, 2025
feat(beta): added an expanded anomaly doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #145