Skip to content

Accounts: Remove references to the old v1 user model #19125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 11, 2024
Merged

Accounts: Remove references to the old v1 user model #19125

merged 8 commits into from
Nov 11, 2024

Conversation

@rhetoric101
Copy link
Contributor

@rhetoric101 rhetoric101 commented Oct 29, 2024

No description provided.

@rhetoric101 rhetoric101 added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Oct 29, 2024
@rhetoric101 rhetoric101 self-assigned this Oct 29, 2024
@github-actions
Copy link

github-actions bot commented Oct 29, 2024

Hi @rhetoric101 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@rhetoric101 rhetoric101 marked this pull request as draft October 29, 2024 23:33
@github-actions github-actions bot requested a review from jeff-colucci October 29, 2024 23:33
@netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/673247559a0a407d9ec92476
😎 Deploy Preview https://deploy-preview-19125--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 29, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

jeff-colucci
jeff-colucci previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jeff-colucci jeff-colucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found some small changes to be made, happy to approve this now or re-approve after you make them!

@github-actions
Copy link

github-actions bot commented Nov 6, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@rhetoric101
fix(accounts): Remove partnership docs
7f58acd 
Remove new-relic-partnerships.yaml
Remove old user section from accounts.yml
Insert redirects to multi-tenancy
@github-actions
Copy link

github-actions bot commented Nov 7, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@github-actions
Copy link

github-actions bot commented Nov 7, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@github-actions
Copy link

github-actions bot commented Nov 7, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@github-actions
Copy link

github-actions bot commented Nov 8, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

jeff-colucci
jeff-colucci previously approved these changes Nov 8, 2024
View reviewed changes
@rhetoric101 rhetoric101 marked this pull request as ready for review November 8, 2024 21:21
@github-actions github-actions bot requested a review from akristen November 8, 2024 21:22
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@github-actions
Copy link

github-actions bot commented Nov 8, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

paperclypse
paperclypse approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All preview URLs loaded successfully. Looks good! A mammoth effort

@rhetoric101 rhetoric101 merged commit c65c45d into develop Nov 11, 2024
12 of 17 checks passed
@rhetoric101 rhetoric101 deleted the rhs-remove-v1-user-references branch November 11, 2024 18:32
@rhetoric101
Copy link
Contributor Author

rhetoric101 commented Nov 11, 2024

I had to override the approval since GitHub was not in synch with Netlify. This kicked off an automated Jira: https://new-relic.atlassian.net/browse/NR-339219

I am closing this Jira.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akristen akristen Awaiting requested review from akristen

2 more reviewers

@paperclypse paperclypse paperclypse approved these changes

@jeff-colucci jeff-colucci jeff-colucci left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhetoric101 rhetoric101

Labels

content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhetoric101 @paperclypse @jeff-colucci