Support Name and Property on licenseKeySecret

[pragmaticivan]

Summary

Given a namespace have a secret newrelic-credentials I want to be able to use this secret but pull the ingestion key from the property ingest-key inside the secret.

This is useful for multi-tenant environments where each namespace has a set of Secrets they can use provided by a platform engineering team.

Desired Behavior

apiVersion: newrelic.com/v1alpha2
kind: Instrumentation
metadata:
  labels:
    app.kubernetes.io/name: newrelic-instrumentation-nodejs
  name: newrelic-instrumentation-nodejs
spec:
  agent:
    language: nodejs
    image: newrelic/newrelic-node-init:12
  podLabelSelector:
    matchExpressions:
    - key: app.newrelic.instrumentation
      operator: In
      values: [nodejs]
  licenseKeySecret: 
     name: newrelic-creds
     key: ingest-key

Possible Solution

Support name and key in the CRD, but make key optional.

[yuzujoe]

It seems that only new_relic_license_key is accepted in the current implementation.

https://github.com/newrelic/k8s-agents-operator/blob/main/internal/apm/helper.go#L240-L255
https://github.com/newrelic/k8s-agents-operator/blob/main/internal/apm/helper.go#L45

I agree that it should be possible to switch between an arbitrary value and the default to prevent multiple Secrets from being created.

[mangulonr]

Thanks @yuzujoe for creating this issue.

We will take you request into consideration, although we don't plans to work on it in the short-mid term due to another We will take your request into consideration, although we don't plan to work on it in the short to mid-term due to other important priorities.

We're open to receiving a PR and reviewing it if you're interested in supporting us with the implementation.