Skip to content

Broaden suspends fix #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

Broaden suspends fix #2307

merged 3 commits into from
Apr 14, 2025

Conversation

kanderson250
Copy link
Contributor

Resolves #2285

This PR refactors our check for applying additional return insn processing to depend completely on the feature flag -Dnewrelic.config.class_transformer.clear_return_stacks. When this flag is set to true, the kotlin weaver fix will apply to all methods. When the flag is set to false (default/when the flag is unset), the kotlin weave fix will apply to no methods. A new warning message will appear in the agent logs instructing users to turn the flag on if the class transformer encounters the AIOOBE.

This refactor was made because there isn't a consistent method signature that the Weaver can recognize as having the Kotlin problem; this is only known at the bytecode insn level, once the frames have been analyzed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.50%. Comparing base (ffc0c73) to head (2e66bec).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
...ation/context/InstrumentationClassTransformer.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2307      +/-   ##
============================================
- Coverage     70.51%   70.50%   -0.02%     
+ Complexity    10031    10027       -4     
============================================
  Files           844      844              
  Lines         40619    40614       -5     
  Branches       6158     6157       -1     
============================================
- Hits          28644    28636       -8     
- Misses         9191     9193       +2     
- Partials       2784     2785       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jtduffy
jtduffy previously approved these changes Apr 10, 2025
@kanderson250 kanderson250 merged commit 6d51ccf into main Apr 14, 2025
111 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Java Engineering Board Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Broaden kotlin suspends fix to other methods
3 participants