Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2285
This PR refactors our check for applying additional return insn processing to depend completely on the feature flag
-Dnewrelic.config.class_transformer.clear_return_stacks
. When this flag is set totrue
, the kotlin weaver fix will apply to all methods. When the flag is set tofalse
(default/when the flag is unset), the kotlin weave fix will apply to no methods. A new warning message will appear in the agent logs instructing users to turn the flag on if the class transformer encounters the AIOOBE.This refactor was made because there isn't a consistent method signature that the Weaver can recognize as having the Kotlin problem; this is only known at the bytecode insn level, once the frames have been analyzed.