refactor: Updated config.instrumentation.timers.enabled to false to disable timers.setTimeout and timers.setInterval by default.
#3414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable `timers.setTimeout` and `timers.setInterval` by default.
Co-authored-by: James Sumners <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3414 +/- ##
==========================================
- Coverage 97.73% 97.61% -0.13%
==========================================
Files 393 398 +5
Lines 54014 54191 +177
Branches 1 1
==========================================
+ Hits 52792 52896 +104
- Misses 1222 1295 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsumners-nr
approved these changes
Oct 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Node.js agent instrumented
setTimeoutandsetInterval. This was done many years ago to propagate async context through timers. When we introduced an async context manager based onAsyncLocalStoragethis instrumentation isn't necessary. On top of that, not only did we propagate context but we created segments/spans for these actions. This caused a lot of unncessary segments/spans to show that a setTimeout or setInterval was called. This PR disables the timers instrumentation by default. Aside from creating useless segments/spans, it typically spammed the debug+ level logger because a lot of 3rd party libraries and applications rely onsetTimeoutandsetIntervalto drive internals. You would see a lot of not recordingsetTimeoutsetIntervalbecause it was not in an active transaction. Now, durations of child instrumented actions will be accounted for in the actual functions and not in thesetTimeoutorsetInterval. However, if customers still want this level of observability, they can re-enable the instrumentation viaconfig.instrumentation.timers.enabledtotrueorNEW_RELIC_INSTRUMENTATION_TIMERS_ENABLEDtotrue.Note: I had to open a branch of
@newrelic/apollo-server-pluginto fix segment trees without timers. That PR will fail until we release the agent.Related Issues
Closes #3084