fix: Updated ioredis instrumentation to handle breakage of errors when using .pipeline.
#3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
reviewed
Oct 23, 2025
jsumners-nr
reviewed
Oct 23, 2025
chanin when using `.pipeline`.
fb050fc to
9611270
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3457 +/- ##
==========================================
- Coverage 97.75% 97.62% -0.14%
==========================================
Files 405 405
Lines 54698 54720 +22
Branches 1 1
==========================================
- Hits 53469 53418 -51
- Misses 1229 1302 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ioredis instrumentation to handle breakage of promise chanin when using .pipeline.ioredis instrumentation to handle breakage of errors when using .pipeline.
jsumners-nr
approved these changes
Oct 23, 2025
amychisholm03
approved these changes
Oct 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a fun one and I explain the fix in the comments of
lib/subscribers/ioredis/index.js. tl;dr: ioredis breaks promise chains and we expose that when usingtracePromise.We didn't catch this when we migrated ioredis because we lacked both error tests and pipeline tests. This PR adds those to avoid future regressions.
Related Links
Closes #3448.