NetConn adapter

[nhooyr]

Was going through some random reading and I noticed this is an issue that appeared multiple times on the gorilla/websocket tracker:

• Question: Any way to safely get a ReadWriteCloser compatible with x/net/websocket? gorilla/websocket#282 (comment)
• websocket.Conn is so close to net.Conn, but not quite gorilla/websocket#441

People using nhooyr/websocket also have ran into this: #80

With my solution in #87, this is relatively simple to implement.

I'm thinking websocket.NetConn(c *websocket.Conn) net.Conn

[nhooyr]

Maybe not net.Conn but at least io.ReadWriteCloser as SetDeadline won't work as expected as described in #80.

But at that point, it seems not nearly as useful. 🤔

[nhooyr]

I think net.Conn is fine with the documented limitation. It's unfortunate but will work fine for 99% of use cases.

[jancona]

I just ran into this while trying to use net/rpc. rpc.NewClient() and rpc.ServeConn() both take io.ReadWriteCloser. So even that rather than a full net.Conn would work for me.

[nhooyr]

sg.

Out of curiosity, why use net/rpc with websockets?

[nhooyr]

@jancona could you test the latest master to ensure it works properly with your code?

[jancona]

It seems like every Read() by the client terminates with an EOF. Is that expected behavior? (I'm not a websockets expert.) In any case, that causes problems for net/rpc which seems to be expecting a stream.

You asked earlier about my use case for net/rpc. I have a Go server and a GopherJS client running in the browser. I want to use net/rpc to allow the server to call a method to display data in the browser. It works using golang.org/x/net/websocket on the server and github.com/gopherjs/websocket on the client. Since golang.org/x/net/websocket is deprecated, I was looking to switch to this package. I know it's a weird use case and I don't blame you if you don't see much value in supporting it! Let me know if you want to pursue this. If so, I can put together a minimal test case.

[nhooyr]

It seems like every Read() by the client terminates with an EOF. Is that expected behavior? (I'm not a websockets expert.) In any case, that causes problems for net/rpc which seems to be expecting a stream.

Definitely not. It's a bug, will fix, thank you for testing.

You asked earlier about my use case for net/rpc. I have a Go server and a GopherJS client running in the browser. I want to use net/rpc to allow the server to call a method to display data in the browser. It works using golang.org/x/net/websocket on the server and github.com/gopherjs/websocket on the client. Since golang.org/x/net/websocket is deprecated, I was looking to switch to this package. I know it's a weird use case and I don't blame you if you don't see much value in supporting it! Let me know if you want to pursue this. If so, I can put together a minimal test case.

Seems reasonable to me.

[nhooyr]

Thanks again for testing. I believe I fixed the bug + added a test, please try again @jancona.