Add support for substring matching within output assertion #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirisuzanne
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Looks good on my end. I left extremely minor lint suggestions. @jgerigmeyer if the JS looks good to you, I think it's good to go. Thanks, @DT3264!
jgerigmeyer
reviewed
Jun 20, 2025
|
Addressed suggestions including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expand true assert to allow for sub-string matching.
Add a new assert function
contains-stringto allow for substrings to be matched within the output of an assert block.Related Issue(s)
See #302 - Expand true.contains to support substring matching
Steps to test/reproduce
Tested through
npm testPlease let me know any comments and feedback, specially on testing since I am not 100% confident that the tests from the initial commit are enough.