Start and finish streaming trace in impl metod #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rm-openai Is there any problem here, please viewit very much, 🌹🌹 |
pakrym-oai
reviewed
Apr 21, 2025
| @@ -404,10 +404,6 @@ def run_streamed( | |||
| disabled=run_config.tracing_disabled, | |||
| ) | |||
| ) | |||
| # Need to start the trace here, because the current trace contextvar is captured at | |||
There was a problem hiding this comment.
I might be wrong but won't this break the following use case:
result = Runner.run_streamed(
agent, "Write ten haikus about recursion in programming."
)
i = 0
async for event in result.stream_events():
with custom_span("Processing event " + str(i)):
print(event)
i += 1
There was a problem hiding this comment.
Yup, you're right. Talked on slack, the fix for this would be to manually attach to the trace via:
async for event in result.stream_events():
with custom_span("Processing event " + str(i), parent=result.trace):
print(event)
i += 1
pakrym-oai
approved these changes
Apr 21, 2025
pakrym-oai
approved these changes
Apr 21, 2025
hankun11
pushed a commit
to hankun11/openai-agents-python
that referenced
this pull request
Apr 23, 2025
* upstream/main: Examples: Fix financial_research_agent instructions (openai#573) Adding extra_headers parameters to ModelSettings (openai#550) v0.0.12 (openai#564) Pass through organization/project headers to tracing backend, fix speech_group enum (openai#562) Docs and tests for litellm (openai#561) RFC: automatically use litellm if possible (openai#534) Fix visualize graph filename to without extension. (openai#554) Start and finish streaming trace in impl metod (openai#540) Enable non-strict output types (openai#539) Examples for image inputs (openai#553)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #435 and closes #538.
Unit tests.