util: set r/x permissions for bundle dirs

[estroz]

Description of the change: permissions for generated bundle directories now have r/x permissions for all users (0755).

Motivation for the change: automation tooling should be able to read bundle files.

/cc @camilamacedo86 @hasbro17 @jmrodri

/kind bug

[hasbro17]

LGTM
I thought we had a const defined for file permissions.

[estroz]

@hasbro17 we do. I actually switched the perms to os.ModePerm which is what operator-registry does for metadata/.

[camilamacedo86]

/lgtm
/approve

[jmccormick2001]

this is failing still for me, I'm seeing the following permissions on the manifests directory being created which cause the permission error to surface:

jeffmc@breve:~/projects/memcached-operator/deploy/olm-catalog/memcached-operator$ ls -l
total 0
drwxr-x--- 2 jeffmc jeffmc 104 May 28 10:29 manifests
drwxrwxr-x 2 jeffmc jeffmc 30 May 28 10:29 metadata
drwxrwxr-x 3 jeffmc jeffmc 23 May 28 10:29 tests

if I update the permissions of the manifest directory as follows then the test works as normal:

jeffmc@breve:/projects/memcached-operator/deploy/olm-catalog/memcached-operator$ chmod +rx manifests/
jeffmc@breve:/projects/memcached-operator/deploy/olm-catalog/memcached-operator$ ls -l
total 0
drwxr-xr-x 2 jeffmc jeffmc 104 May 28 10:29 manifests
drwxrwxr-x 2 jeffmc jeffmc 30 May 28 10:29 metadata
drwxrwxr-x 3 jeffmc jeffmc 23 May 28 10:29 tests

[jmrodri]

@estroz @jmccormick2001 seems to me the perm should be 0755 (drwxr-xr-x). Readable and executable by everyone but only writeable by the owner. The previous 0700 (drwx------) is too restrictive and 0777 is wide open. But based on @jmccormick2001 comment seems like even the 777 didn't take.

[estroz]

@jmrodri I chose 0777 to match what operator-registry does. I have a feeling they chose these perms because being able to write arbitrary files to a directory isn't a security risk AFAIK. This may actually be a requirement in pipeline scenarios. Thoughts?

Edit: on second thought lets go with 0755. We can update later if we get complaints.

[jmccormick2001]

perator/
total 0
drwxr-xr-x 2 jeffmc jeffmc 104 May 28 11:47 manifests
drwxrwxr-x 2 jeffmc jeffmc 30 May 28 11:48 metadata
drwxrwxr-x 3 jeffmc jeffmc 23 May 28 11:48 tests
jeffmc@breve:~/projects/memcached-operator$ operator-sdk alpha scorecard ./deploy/olm-catalog/memcached-operator/ --selector=suite=basic
basic-check-spec : pass
CR:
Labels:

bueno.

[jmrodri]

/approve
/lgtm