ci: replace travis completely with github actions #4554
Conversation
releasing with github actions Makefile,release/Makefile: remove multiarch image build targets, since all non-host arch builds can be done in action configs Signed-off-by: Eric Stroczynski <[email protected]>
Signed-off-by: Eric Stroczynski <[email protected]>
Signed-off-by: Eric Stroczynski <[email protected]>
Signed-off-by: Eric Stroczynski <[email protected]>
|
For some reason GitHub Environments weren't injecting environment variable secrets into #4544. The steps requiring those variables are now gated by |
|
/cc @joelanford @jmrodri |
|
@estroz The secrets are only injected in builds that originate from this repo (e.g. push and tag builds). It would be a security concern if secrets were exposed to PRs because malicious users could submit PRs to harvest credentials, etc. |
Ah duh that makes sense. I tested this on my own fork so obviously it worked there 😅. |
.github/workflows/deploy.yml
Outdated
| context: . | ||
| # s390x is not supported by the scorecard-test-kuttl base image. | ||
| platforms: linux/amd64,linux/arm64,linux/ppc64le${{ matrix.id != 'scorecard-test-kuttl' && ',linux/s390x' || '' }} | ||
| push: ${{ (github.event_name != 'pull_request' && (startsWith(github.ref, 'refs/tags/') || github.ref == 'refs/heads/master')) }} |
There was a problem hiding this comment.
Is it possible to use ${{ github.event.repository.default_branch }} everywhere we reference master in this file?
That way if we ever change the default branch, we don't have to remember to change it here.
|
Related: #4555 |
Signed-off-by: Eric Stroczynski <[email protected]>
Signed-off-by: Eric Stroczynski <[email protected]>
Recreation of #4544.
Description of the change:
Motivation for the change: for various reasons (cost, reliability, debuggability, visibility) Travis is no longer viable for the operator-sdk project. Github Actions, via
docker buildx, can support cross-platform image builds, release automation, and is way more configurable/ergonomic.This work is based off of https://github.com/joelanford/helm-operator/blob/7fe2dd3/.github/workflows/deploy.yml.
Closes #3984
/area testing
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs