Skip to content

PERF: unnecessary casting in merge #44240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
jbrockmendel opened this issue Oct 30, 2021 · 2 comments · Fixed by #49876
Closed
3 tasks done

PERF: unnecessary casting in merge #44240

jbrockmendel opened this issue Oct 30, 2021 · 2 comments · Fixed by #49876
Labels
Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Comments

@jbrockmendel
Copy link
Member

  • I have checked that this issue has not already been reported.

  • I have confirmed this issue exists on the latest version of pandas.

  • I have confirmed this issue exists on the master branch of pandas.

Reproducible Example

In reshape.merge we do some some casting motivated by what dtypes HashTable supports, see the comment '# upcast 'by' parameter because HashTable is limited'. That comment is no longer accurate, and we can avoid some of this casting. Something like core.algorithms._ensure_data may be reusable.

Installed Versions

Replace this line with the output of pd.show_versions()

Prior Performance

No response

@jbrockmendel jbrockmendel added Performance Memory or execution speed performance Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 30, 2021
@mroeschke mroeschke added Reshaping Concat, Merge/Join, Stack/Unstack, Explode and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 30, 2021
@jbrockmendel
Copy link
Member Author

@phofl i think one of your recent PRs might have addressed this?

@phofl
Copy link
Member

phofl commented Nov 22, 2022

I am in the process of finishing the final pr, will link to this issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants