fix(op): set optimism flag correctly #6593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
commented
Feb 13, 2024
| } | ||
|
|
||
| #[cfg(not(feature = "optimism"))] | ||
| let cfg_with_handler_cfg = CfgEnvWithHandlerCfg::new(cfg, spec_id); |
Collaborator
Author
There was a problem hiding this comment.
If we use ::new here is_optimism flag would be set to false
rakita
commented
Feb 13, 2024
crates/rpc/rpc/src/eth/api/call.rs
Outdated
|
|
||
| let cfg_with_spec_id = CfgEnvWithHandlerCfg::new(env.cfg.clone(), env.handler_cfg.spec_id); | ||
| let cfg_with_spec_id = | ||
| CfgEnvWithHandlerCfg { cfg_env: env.cfg.clone(), handler_cfg: env.handler_cfg.clone() }; |
Collaborator
Author
There was a problem hiding this comment.
Here is_optimism flag would be lost
Rjected
approved these changes
Feb 13, 2024
Member
Rjected
left a comment
There was a problem hiding this comment.
I see, yeah setting if is_optimism makes sense here. would also add docs saying that is_optimism is set to false when new is used
1 task
Collaborator
Author
Have added the proper constructor here: bluealloy/revm#1087 Where did you mean to add the doc in revm? |
Member
Just above |
mattsse
reviewed
Feb 13, 2024
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
I'm losing my mind with the semicolon back and forth
Contributor
|
unfortunately still seeing the same i thought fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In two places we didn't set optimism flag
In the Node builder trait in
crates/node-api/src/engine/traits.rs. @mattsse check if this is a bug or not, maybe it is overwritten.And in
crates/rpc/rpc/src/eth/api/call.rsflag would be lost.Will add proper constructors to revm but to fix it asap this should be fine
should close #6593