Skip to content

Commit 1287747

Browse files
ext: make various internal functions static (#10650)
Namely in: * ext/date * ext/libxml * ext/dba * ext/curl
1 parent ff2a211 commit 1287747

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

ext/curl/multi.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ static zend_function *curl_multi_get_constructor(zend_object *object) {
523523
return NULL;
524524
}
525525

526-
void curl_multi_free_obj(zend_object *object)
526+
static void curl_multi_free_obj(zend_object *object)
527527
{
528528
php_curlm *mh = curl_multi_from_obj(object);
529529

ext/date/php_date.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ static timelib_tzinfo *php_date_parse_tzfile(const char *formal_tzname, const ti
520520
return tzi;
521521
}
522522

523-
timelib_tzinfo *php_date_parse_tzfile_wrapper(const char *formal_tzname, const timelib_tzdb *tzdb, int *dummy_error_code)
523+
static timelib_tzinfo *php_date_parse_tzfile_wrapper(const char *formal_tzname, const timelib_tzdb *tzdb, int *dummy_error_code)
524524
{
525525
return php_date_parse_tzfile(formal_tzname, tzdb);
526526
}
@@ -2947,7 +2947,7 @@ PHP_FUNCTION(date_get_last_errors)
29472947
}
29482948
/* }}} */
29492949

2950-
void php_date_do_return_parsed_time(INTERNAL_FUNCTION_PARAMETERS, timelib_time *parsed_time, timelib_error_container *error) /* {{{ */
2950+
static void php_date_do_return_parsed_time(INTERNAL_FUNCTION_PARAMETERS, timelib_time *parsed_time, timelib_error_container *error) /* {{{ */
29512951
{
29522952
zval element;
29532953

ext/dba/dba.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ static void dba_close_rsrc(zend_resource *rsrc)
293293
/* }}} */
294294

295295
/* {{{ dba_close_pe_rsrc_deleter */
296-
int dba_close_pe_rsrc_deleter(zval *el, void *pDba)
296+
static int dba_close_pe_rsrc_deleter(zval *el, void *pDba)
297297
{
298298
if (Z_RES_P(el)->ptr == pDba) {
299299
if (Z_DELREF_P(el) == 0) {
@@ -318,7 +318,7 @@ static void dba_close_pe_rsrc(zend_resource *rsrc)
318318
/* }}} */
319319

320320
/* {{{ PHP_INI */
321-
ZEND_INI_MH(OnUpdateDefaultHandler)
321+
static ZEND_INI_MH(OnUpdateDefaultHandler)
322322
{
323323
const dba_handler *hptr;
324324

@@ -431,7 +431,7 @@ static void php_dba_update(INTERNAL_FUNCTION_PARAMETERS, int mode)
431431
/* }}} */
432432

433433
/* {{{ php_find_dbm */
434-
dba_info *php_dba_find(const char* path)
434+
static dba_info *php_dba_find(const char* path)
435435
{
436436
zend_resource *le;
437437
dba_info *info;

ext/libxml/libxml.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -707,7 +707,7 @@ PHP_LIBXML_API void php_libxml_ctx_warning(void *ctx, const char *msg, ...)
707707
va_end(args);
708708
}
709709

710-
PHP_LIBXML_API void php_libxml_structured_error_handler(void *userData, xmlErrorPtr error)
710+
static void php_libxml_structured_error_handler(void *userData, xmlErrorPtr error)
711711
{
712712
_php_list_set_error_structure(error, NULL);
713713

ext/sqlite3/sqlite3.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ static void sqlite3_param_dtor(zval *data);
3939
static int php_sqlite3_compare_stmt_zval_free(php_sqlite3_free_list **free_list, zval *statement);
4040

4141
/* {{{ Error Handler */
42-
static void php_sqlite3_error(php_sqlite3_db_object *db_obj, char *format, ...)
42+
static void php_sqlite3_error(php_sqlite3_db_object *db_obj, const char *format, ...)
4343
{
4444
va_list arg;
4545
char *message;

0 commit comments

Comments
 (0)