Skip to content

Commit 334ecbe

Browse files
committedJan 15, 2023
Update UPGRADING.INTERNALS with the changes made to php_url_encode_hash_ex()
1 parent 540e510 commit 334ecbe

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed
 

‎UPGRADING.INTERNALS

+17
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,23 @@ PHP 8.3 INTERNALS UPGRADE NOTES
4343
- A new function php_json_validate_ex has been added to check if the
4444
provided C string is valid for the given depth and options.
4545

46+
b. ext/standard
47+
- The PHPAPI php_url_encode_hash_ex() function has had its signature change
48+
from:
49+
PHPAPI void php_url_encode_hash_ex(HashTable *ht, smart_str *formstr,
50+
const char *num_prefix, size_t num_prefix_len,
51+
const char *key_prefix, size_t key_prefix_len,
52+
const char *key_suffix, size_t key_suffix_len,
53+
zval *type, const char *arg_sep, int enc_type);
54+
to:
55+
PHPAPI void php_url_encode_hash_ex(HashTable *ht, smart_str *formstr,
56+
const char *num_prefix, size_t num_prefix_len,
57+
const zend_string *key_prefix,
58+
zval *type, const zend_string *arg_sep, int enc_type);
59+
The change to use zend_string prevent the computation of the arg_sep
60+
length at each call. The key_suffix parameter was dropped as it was a
61+
constant value and depended on the key_prefix parameter to not be NULL.
62+
4663
========================
4764
4. OpCode changes
4865
========================

0 commit comments

Comments
 (0)
Please sign in to comment.