Skip to content

Commit 7817fc0

Browse files
committed
Deny cloning of fileinfo objects
Using a cloned finfo object will crash.
1 parent be6d72b commit 7817fc0

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

ext/fileinfo/fileinfo.c

+1
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ PHP_MINIT_FUNCTION(finfo)
218218
memcpy(&finfo_object_handlers, &std_object_handlers, sizeof(zend_object_handlers));
219219
finfo_object_handlers.offset = XtOffsetOf(finfo_object, zo);
220220
finfo_object_handlers.free_obj = finfo_objects_free;
221+
finfo_object_handlers.clone_obj = NULL;
221222

222223
le_fileinfo = zend_register_list_destructors_ex(finfo_resource_destructor, NULL, "file_info", module_number);
223224

+27
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
--TEST--
2+
Cloning and serializing finfo is not supported
3+
--FILE--
4+
<?php
5+
6+
$finfo = new finfo;
7+
var_dump($finfo->buffer("Test string"));
8+
try {
9+
$finfo2 = clone $finfo;
10+
var_dump($finfo2->buffer("Test string"));
11+
} catch (Error $e) {
12+
echo $e->getMessage(), "\n";
13+
}
14+
try {
15+
$finfo3 = unserialize(serialize($finfo));
16+
var_dump($finfo3->buffer("Test string"));
17+
} catch (Error $e) {
18+
echo $e->getMessage(), "\n";
19+
}
20+
21+
?>
22+
--EXPECTF--
23+
string(%d) "%s"
24+
Trying to clone an uncloneable object of class finfo
25+
26+
Warning: finfo::buffer(): The invalid fileinfo object. in %s on line %d
27+
bool(false)

0 commit comments

Comments
 (0)