Fix always non-null warning

nikic · nikic · commit 9f9042fd43b1 · 2022-09-11T22:13:01.000+02:00
ZSTR_VAL can not be null.
diff --git a/ext/mbstring/mbstring.c b/ext/mbstring/mbstring.c
@@ -761,7 +761,7 @@ static PHP_INI_MH(OnUpdate_mbstring_http_input)
 		php_error_docref("ref.mbstring", E_DEPRECATED, "Use of mbstring.http_input is deprecated");
 	}
 
-	if (!new_value || !ZSTR_VAL(new_value)) {
+	if (!new_value) {
 		const char *encoding = php_get_input_encoding();
 		MBSTRG(http_input_set) = 0;
 		_php_mb_ini_mbstring_http_input_set(encoding, strlen(encoding));

Original file line number	Diff line number	Diff line change
`@@ -761,7 +761,7 @@ static PHP_INI_MH(OnUpdate_mbstring_http_input)`
`761`	`761`	`php_error_docref("ref.mbstring", E_DEPRECATED, "Use of mbstring.http_input is deprecated");`
`762`	`762`	`}`
`763`	`763`
`764`		`- if (!new_value \|\| !ZSTR_VAL(new_value)) {`
	`764`	`+ if (!new_value) {`
`765`	`765`	`const char *encoding = php_get_input_encoding();`
`766`	`766`	`MBSTRG(http_input_set) = 0;`
`767`	`767`	`_php_mb_ini_mbstring_http_input_set(encoding, strlen(encoding));`