Fix GH-12282: IntlDateFormatter::construct should throw an exception is the locale field has an invalid value.

Close GH-12282

Author: devnexen

NEWS

@@ -18,6 +18,8 @@ PHP                                                                        NEWS
 - Intl:
   . Fixed bug GH-12243 (segfault on IntlDateFormatter::construct).
     (David Carlier)
+  . Fixed bug GH-12282 (IntlDateFormatter::construct should throw an exception
+    on an invalid locale). (David Carlier)
 
 - PCRE:
   . Fixed bug GH-11956 (Backport upstream fix, PCRE regular expressions with

ext/intl/dateformat/dateformat_create.cpp

@@ -111,6 +111,11 @@ static zend_result datefmt_ctor(INTERNAL_FUNCTION_PARAMETERS, zend_error_handlin
 		locale_str = (char *) intl_locale_get_default();
 	}
 	locale = Locale::createFromName(locale_str);
+	/* get*Name accessors being set does not preclude being bogus */
+	if (locale.isBogus() || strlen(locale.getISO3Language()) == 0) {
+		intl_error_set(NULL, U_ILLEGAL_ARGUMENT_ERROR, "datefmt_create: invalid locale", 0);
+		return FAILURE;
+	}
 
 	/* process calendar */
 	if (datefmt_process_calendar_arg(calendar_obj, calendar_long, calendar_is_null, locale, "datefmt_create",

ext/intl/tests/gh12282.phpt

@@ -0,0 +1,21 @@
+--TEST--
+GitHub #12282 IntlDateFormatter::locale with invalid value.
+--EXTENSIONS--
+intl
+--FILE--
+<?php
+
+try {
+    new IntlDateFormatter(
+	'xx',
+	IntlDateFormatter::FULL,
+	IntlDateFormatter::FULL,
+	null,
+	null,
+	'w'
+    );
+} catch (\IntlException $e) {
+    echo $e->getMessage();
+}
+--EXPECT--
+datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROR