ext/gd: imagerotate removes ignore_transparent argument.

seems to be a relic of PHP 5 but no longer makes sense in regard of gdImageRotateInterpolated.

Close GH-11426

Author: devnexen

NEWS

@@ -14,6 +14,10 @@ PHP                                                                        NEWS
   . Fix #77894 (DOMNode::C14N() very slow on generated DOMDocuments even after
     normalisation). (nielsdos)
 
+- GD:
+  . Removed imagerotate "ignore_transparent" argument since it has no effect.
+    (David Carlier)
+
 - Streams:
   . Implement GH-8641 (STREAM_NOTIFY_COMPLETED over HTTP never emitted).
     (nielsdos, Jakub Zelenka)

UPGRADING

@@ -112,6 +112,10 @@ PHP 8.3 UPGRADE NOTES
 - Dom:
   . Changed DOMCharacterData::appendData() tentative return type to true.
 
+- Gd:
+  . Changed imagerotate signature, removed the `ignore_transparent` argument
+    as it was not used internally anyway from PHP 7.x.
+
 - Intl:
   . datefmt_set_timezone (and its alias IntlDateformatter::setTimeZone) 
     now returns true on success, previously null was returned.

ext/gd/gd.c

@@ -1189,9 +1189,8 @@ PHP_FUNCTION(imagerotate)
 	gdImagePtr im_dst, im_src;
 	double degrees;
 	zend_long color;
-	bool ignoretransparent = 0;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS(), "Odl|b", &SIM, gd_image_ce,  &degrees, &color, &ignoretransparent) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "Odl", &SIM, gd_image_ce,  &degrees, &color) == FAILURE) {
 		RETURN_THROWS();
 	}
 

ext/gd/gd.stub.php

@@ -530,9 +530,8 @@ function imagegrabscreen(): GdImage|false {}
 
 #endif
 
-// TODO: $ignore_transparent is ignored???
 /** @refcount 1 */
-function imagerotate(GdImage $image, float $angle, int $background_color, bool $ignore_transparent = false): GdImage|false {}
+function imagerotate(GdImage $image, float $angle, int $background_color): GdImage|false {}
 
 function imagesettile(GdImage $image, GdImage $tile): bool {}