You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix various namespace prefix conflict resolution bugs and namespace shift bugs
There are two linked issues:
- Conflicts couldn't be resolved by changing the prefix name.
- Lacking a prefix would shift the namespace as the default namespace,
causing elements to suddenly become part of the namespace instead of
the attributes.
The output could still be improved by removing redundant namespace
declarations, but that's another issue. At least the output is
correct now.
ClosesGH-11777.
/* Either memory allocation failure, or it's because of a prefix conflict.
1604
+
* We'll assume a conflict and try again. If it was a memory allocation failure we'll just fail again, whatever.
1605
+
* This isn't needed for every caller (such as createElementNS & DOMElement::__construct), but isn't harmful and simplifies the mental model "when do I use which function?".
1606
+
* This branch will also be taken unlikely anyway as in those cases it'll be for allocation failure. */
0 commit comments