Fix rc info of iterator_to_array (#9080)

iluuu1994 · web-flow · commit d4a9cc885614 · 2022-07-21T15:05:34.000+02:00
This function can now return a copy of the provided array, resulting in
a value of RC != 1.
diff --git a/Zend/Optimizer/zend_func_infos.h b/Zend/Optimizer/zend_func_infos.h
@@ -444,7 +444,6 @@ static const func_info_t func_infos[] = {
 	F1("class_uses", MAY_BE_ARRAY|MAY_BE_ARRAY_KEY_STRING|MAY_BE_ARRAY_OF_STRING|MAY_BE_FALSE),
 	F1("spl_classes", MAY_BE_ARRAY|MAY_BE_ARRAY_KEY_STRING|MAY_BE_ARRAY_OF_STRING),
 	F1("spl_object_hash", MAY_BE_STRING),
-	F1("iterator_to_array", MAY_BE_ARRAY|MAY_BE_ARRAY_KEY_LONG|MAY_BE_ARRAY_KEY_STRING|MAY_BE_ARRAY_OF_ANY|MAY_BE_ARRAY_OF_REF),
 	F1("ob_get_flush", MAY_BE_STRING|MAY_BE_FALSE),
 	F1("ob_get_clean", MAY_BE_STRING|MAY_BE_FALSE),
 	F1("ob_list_handlers", MAY_BE_ARRAY|MAY_BE_ARRAY_KEY_LONG|MAY_BE_ARRAY_OF_STRING),
diff --git a/ext/spl/php_spl.stub.php b/ext/spl/php_spl.stub.php
@@ -50,5 +50,4 @@ function iterator_apply(Traversable $iterator, callable $callback, ?array $args
 
 function iterator_count(iterable $iterator): int {}
 
-/** @refcount 1 */
 function iterator_to_array(iterable $iterator, bool $preserve_keys = true): array {}
diff --git a/ext/spl/php_spl_arginfo.h b/ext/spl/php_spl_arginfo.h

Original file line number	Diff line number	Diff line change
`@@ -50,5 +50,4 @@ function iterator_apply(Traversable $iterator, callable $callback, ?array $args`
`50`	`50`
`51`	`51`	`function iterator_count(iterable $iterator): int {}`
`52`	`52`
`53`		`-/** @refcount 1 */`
`54`	`53`	`function iterator_to_array(iterable $iterator, bool $preserve_keys = true): array {}`