Skip to content

Commit dc9adda

Browse files
committed
Fix return value of _php_server_push_callback in case of failure
It should return CURL_PUSH_DENY by default instead of CURL_PUSH_OK in the branch I added, just like the check above. I forgot to change this after doing tests.
1 parent 3ccd8d7 commit dc9adda

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ext/curl/multi.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ static int _php_server_push_callback(CURL *parent_ch, CURL *easy, size_t num_hea
384384

385385
if (UNEXPECTED(zend_fcall_info_init(&t->func_name, 0, &fci, &t->fci_cache, NULL, NULL) == FAILURE)) {
386386
php_error_docref(NULL, E_WARNING, "Cannot call the CURLMOPT_PUSHFUNCTION");
387-
return CURL_PUSH_OK;
387+
return rval;
388388
}
389389

390390
parent = Z_CURL_P(pz_parent_ch);

0 commit comments

Comments
 (0)