Skip to content

Commit e1967ca

Browse files
authored
Change DOMCharacterData::appendData return type to true (#10690)
1 parent 7c44baa commit e1967ca

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

UPGRADING

+3
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ PHP 8.3 UPGRADE NOTES
7373
See GH-9336
7474
. class_alias() now supports creating an alias of an internal class.
7575

76+
- Dom:
77+
. Changed DOMCharacterData::appendData() tentative return type to true.
78+
7679
- MBString:
7780
. mb_strtolower, mb_strtotitle, and mb_convert_case implement conditional
7881
casing rules for the Greek letter sigma. For mb_convert_case, conditional

ext/dom/php_dom.stub.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ class DOMCharacterData extends DOMNode implements DOMChildNode
485485
public ?DOMElement $nextElementSibling;
486486

487487
/** @tentative-return-type */
488-
public function appendData(string $data): bool {}
488+
public function appendData(string $data): true {}
489489

490490
/** @return string|false */
491491
public function substringData(int $offset, int $count) {}

ext/dom/php_dom_arginfo.h

+4-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)