Zend: Fix memory leak in ++/-- when overloading fetch access

Closes GH-11859

Author: Girgias

Zend/tests/in-de-crement/overloaded_access.phpt

@@ -0,0 +1,36 @@
+--TEST--
+Overloaded array access with pre increment/decrement
+--FILE--
+<?php
+set_error_handler(function($severity, $m) {
+	if (str_starts_with($m, 'Indirect modification of overloaded element')) { return; }
+	throw new Exception($m, $severity);
+});
+class Foo implements ArrayAccess {
+    function offsetGet($index): mixed {
+        return range(1, 5);
+    }
+    function offsetSet($index, $newval): void {
+    }
+    function offsetExists($index): bool {
+        return true;
+    }
+    function offsetUnset($index): void {
+    }
+}
+$foo = new Foo;
+try {
+	$foo[0]++;
+} catch (Throwable $ex) {
+	echo $ex->getMessage() . "\n";
+}
+$foo = new Foo;
+try {
+	$foo[0]--;
+} catch (Throwable $ex) {
+	echo $ex->getMessage() . "\n";
+}
+?>
+--EXPECT--
+Cannot increment array
+Cannot decrement array

Zend/zend_vm_def.h

@@ -1500,13 +1500,6 @@ ZEND_VM_HELPER(zend_pre_inc_helper, VAR|CV, ANY)
 			}
 		}
 		increment_function(var_ptr);
-		if (UNEXPECTED(EG(exception))) {
-			/* Smart branch expects result to be set with exceptions */
-			if (UNEXPECTED(RETURN_VALUE_USED(opline))) {
-				ZVAL_NULL(EX_VAR(opline->result.var));
-			}
-			HANDLE_EXCEPTION();
-		}
 	} while (0);
 
 	if (UNEXPECTED(RETURN_VALUE_USED(opline))) {
@@ -1559,13 +1552,6 @@ ZEND_VM_HELPER(zend_pre_dec_helper, VAR|CV, ANY)
 			}
 		}
 		decrement_function(var_ptr);
-		if (UNEXPECTED(EG(exception))) {
-			/* Smart branch expects result to be set with exceptions */
-			if (UNEXPECTED(RETURN_VALUE_USED(opline))) {
-				ZVAL_NULL(EX_VAR(opline->result.var));
-			}
-			HANDLE_EXCEPTION();
-		}
 	} while (0);
 
 	if (UNEXPECTED(RETURN_VALUE_USED(opline))) {