posix_getgr(gid|nam)_basic.phpt fail

[fpcarv]

Description

php_test_results_20230101_2044.txt

PHP Version

PHP 8.2.1RC1

Operating System

Linux 5.15.85 (CRUX)

[nielsdos]

There are three test failures in your report:

• Compatibility of values of same name trait constants is checked after their constant expressions are evaluated [Zend/tests/traits/constant_016.phpt]
• Test posix_getgrgid() function : basic functionality [ext/posix/tests/posix_getgrgid_basic.phpt]
• Test posix_getgrnam() function : basic functionality [ext/posix/tests/posix_getgrnam_basic.phpt]

The first one was reported before and is fixed by the commit referenced in #10133 AFAICT.

For the other two I used the following patch to fix the issues you're encountering:

diff --git a/ext/posix/tests/posix_getgrgid_basic.phpt b/ext/posix/tests/posix_getgrgid_basic.phpt
index 6b0daa5e94..392e81d491 100644
--- a/ext/posix/tests/posix_getgrgid_basic.phpt
+++ b/ext/posix/tests/posix_getgrgid_basic.phpt
@@ -17,7 +17,7 @@
 Array
 (
     [name] => %s
-    [passwd] => %a
+    [passwd] => %A
     [members] => Array
 %a
 
diff --git a/ext/posix/tests/posix_getgrnam_basic.phpt b/ext/posix/tests/posix_getgrnam_basic.phpt
index 5203d1ea0f..acf8f4473e 100644
--- a/ext/posix/tests/posix_getgrnam_basic.phpt
+++ b/ext/posix/tests/posix_getgrnam_basic.phpt
@@ -20,7 +20,7 @@
   ["name"]=>
   string(%d) "%s"
   ["passwd"]=>
-  string(1) "%s"
+  string(%d) "%S"
   ["members"]=>
 %a
   ["gid"]=>

You can apply this patch on top of the 8.2 branch using the git apply command. Could you please verify whether it fixes your issue?

[fpcarv]

It worked :-)
Thanks!

[cmb69]

So passwd is an empty string for both tests? If so, the patch looks good to me. Do you want to make a PR, @nielsdos?

[nielsdos]

Yes and yes.