Skip to content

FPM successful config test early exit #10385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bukka opened this issue Jan 20, 2023 · 1 comment
Closed

FPM successful config test early exit #10385

bukka opened this issue Jan 20, 2023 · 1 comment

Comments

@bukka
Copy link
Member

bukka commented Jan 20, 2023

Description

ASAN does not like early exits without freeing all memory. One such path is in FPM when config test is done successfully:

if (fpm_globals.test_successful) {
exit(FPM_EXIT_OK);

The test that triggers that is sapi/fpm/tests/socket-uds-numeric-ugid-nonroot.phpt and one such failed job can be seen at https://github.com/php/php-src/actions/runs/3926296131/jobs/6711897592 .

This should be fixed and SAPI cleanly shut down.

PHP Version

PHP 8.x

Operating System

No response

@nielsdos
Copy link
Member

I can probably take a look at this tonight if no one else is working on this yet / if no one else has planned to work on this :)

nielsdos added a commit to nielsdos/php-src that referenced this issue Jan 20, 2023
This introduces an enum `fpm_init_return_status` to propagate the status
up to fpm_main. This also makes the code clearer by not using magic
integer return numbers.
@bukka bukka closed this as completed in 5b13e83 Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@bukka @nielsdos and others