Skip to content

run-tests.php diff dump is broken #10806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mvorisek opened this issue Mar 7, 2023 · 0 comments
Closed

run-tests.php diff dump is broken #10806

mvorisek opened this issue Mar 7, 2023 · 0 comments
Labels
Bug Status: Needs Triage

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Mar 7, 2023

Description

image

repro file: https://github.com/php/php-src/blob/7c70cd00691a141750ab61aacc9bf3e7def3134e/ext/zend_test/tests/strings_marked_as_utf8.phpt

notice explode: is missing in the output, it seems the last line before the colored diff seems to be wrongly omit, making the diff very difficult to understand

PHP Version

any

Operating System

any
iluuu1994 added a commit to iluuu1994/php-src that referenced this issue Mar 18, 2023
@iluuu1994
Implement better diff for run-tests.php
0996960 
Diffing algorithm is borrowed from bless_tests.php

Fixes phpGH-10806
@iluuu1994 iluuu1994 mentioned this issue Mar 18, 2023
Closed
iluuu1994 added a commit to iluuu1994/php-src that referenced this issue Mar 18, 2023
@iluuu1994
Implement better diff for run-tests.php
e5e8366 
Diffing algorithm is borrowed from bless_tests.php

Fixes phpGH-10806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement better diff for run-tests.php iluuu1994/php-src
1 participant
@mvorisek