-
Notifications
You must be signed in to change notification settings - Fork 7.8k
PHP Build Failed - Test curl_version() basic functionality [ext/curl/tests/curl_version_basic_001.phpt] #10928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
…nality [ext/curl/tests/curl_version_basic_001.phpt] It's possible that curl was compiled without SSL, and/or without libz support. In the case of the issue reporter it was without libz support. This causes the test to fail because we expect a non-empty string. Fix it by using %S instead of %s to allow empty strings.
You can safely ignore this error. The test expected the libz version string to be non-empty, but if curl is compiled without libz support it can be empty. I fixed the test in the linked PR. |
Oh my word thank goodness. You know like sometimes you see an error pop up and you just imagine the worst reasons, as if every little error log is an end of a world scenario. Yeah dude @aws look at what you are causing, stop making me angry at everything. |
* PHP-8.1: Fix GH-10928: PHP Build Failed - Test curl_version() basic functionality [ext/curl/tests/curl_version_basic_001.phpt]
* PHP-8.2: Fix GH-10928: PHP Build Failed - Test curl_version() basic functionality [ext/curl/tests/curl_version_basic_001.phpt]
Looks like you merged a branch containing a candidate mediation that didn't pass the checks, are you sure you want to close this issue? And, I have not had a chance to verify that this resolved the failed test on my end. Are you sure you want to close out this issue I believe this isn't a best practice especially for ensuring issues are tracked appropriately especially for a project this largely collaborated. |
The reason it shows a red X is because when I pushed it, shortly after someone else pushed their changes. So my build got cancelled. Unfortunately, github then shows a red X instead of a symbol for build cancelled. I verified on my end the issue is resolved. If you still encounter the issue let me know and I'll reopen this one. |
I appreciate the closing remarks and sounds good to me. Thanks. |
Description
I'm trying to build my own PHP to better understand how to optimize my shitty wordpress server towards a bottom up approach rather than a top down caching perspective. I don't know what this means. It just says to open up a report. Thank you. You can visit the wordpress server as well here.
Any suggestions are appreciated. Thanks.
PHP Version
8.3.0-dev
Operating System
Ubuntu 22.04.2 LTS
The text was updated successfully, but these errors were encountered: