-
Notifications
You must be signed in to change notification settings - Fork 7.8k
cli/get_set_process_title fails on MacOS #11246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Fail to clobber_error only when the argv is a non-contiguous area Don't increment the end_of_error if a non-contiguous area is encountered in environ
…on MacOS Patch for PHP >= 8.2 due to commit b468d6f
Is there anyone who can triage this? 2 PRs have been submitted for PHP8.1 (#11247), and PHP8.2 (#11273). I find projects that have patched over this by just ignoring Darwin based OS for example Synfony Console symfony/symfony#21076 |
@lucasnetau I have an old Mac and so I'll have a look today. |
Thank you. I only have macOS 13.3 boxes around but I replicated on both Intel and M1. The target version in CI is only 11 for macOS. |
Fail to clobber_error only when the argv is a non-contiguous area Don't increment the end_of_error if a non-contiguous area is encountered in environ Closes GH-11247
* PHP-8.1: Fix bug GH-11246 cli/get_set_process_title
* PHP-8.2: Fix bug GH-11246 cli/get_set_process_title
Fixed in c6ae7a5. |
Description
The following code:
Resulted in this output:
But I expected this output instead:
What was strange with this one it works from bash shells within PHPStorm, but fails on subprocesses (proc_open) or when php cli run from Terminal.
Tracing the issue finds that there may not be a contiguous environ strings following argv, however comparing to the original postgres version and checking the existing source this doesn't appear to be necessary to fail at this point.
I'll raise a PR shortly
PHP Version
PHP 8.1, PHP8.2
Operating System
MacOS
The text was updated successfully, but these errors were encountered: