Skip to content

oci8 / pdo_oci exts are not tested in CI #8346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvorisek opened this issue Apr 12, 2022 · 4 comments
Closed

oci8 / pdo_oci exts are not tested in CI #8346

mvorisek opened this issue Apr 12, 2022 · 4 comments

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Apr 12, 2022

Description

it seems oci8 / pdo_oci exts are built, but not tested in CI, at least there is zero coverage

for some reasons, they are not displayed as SKIP

also, in the CI output I see a lot of lines like:

SKIP PDO Common: PDO::FETCH_ASSOC [ext/pdo/tests/pdo_001.phpt] reason: no driver
SKIP PDO_Firebird: bug 73087 segfault binding blob parameter [ext/pdo_firebird/tests/bug_73087.phpt] reason: : PDO_FIREBIRD_TEST_DSN must be set
SKIP FIREBIRD PDO Common: PDO::FETCH_NUM [ext/pdo_firebird/tests/pdo_002.phpt] reason: SQLSTATE[HY000] [335544721] Unable to complete network request to host "localhost".
SKIP DBA DB1 handler test [ext/dba/tests/dba_db1.phpt] reason: DB1 handler not available
SKIP pspell configs [ext/pspell/tests/004.phpt] reason: English dictionary is not available

and I belive all should be tested instead of skipped

also sapi/cli/php_cli_server.c file has zero coverage

@cmb69
Copy link
Member

cmb69 commented Apr 12, 2022

Well, this is mostly a licensing issue. I can remember that this topic came up a while ago, and that there was hope regarding some free testing licenses, but wouldn't know if that happened in the meantime. Maybe @cjbj knows.

@mvorisek
Copy link
Contributor Author

there is very good gvenzl/oracle-xe:18 Docker image freely available, we use it in our CI pipelines and also Doctrine DBAL project uses it

@cjbj
Copy link
Contributor

cjbj commented Apr 12, 2022

As of last week you can use gvenzl/oracle-xe:slim to get Oracle DB 21.3

Also podman pull container-registry.oracle.com/database/express:latest will pull DB 21.3 XE without needing clickthrough.

@cmb69 cmb69 linked a pull request Apr 12, 2022 that will close this issue
@mvorisek
Copy link
Contributor Author

#8348 was merged, issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants