strcmp return value changed between 8.2 alpha 1 and alpha 2

[TRowbotham]

Description

https://3v4l.org/Iue7N - previous behavior
https://3v4l.org/Iue7N/rfc#vgit.master - behavior in 8.2 alpha 2

I didn't notice this documented in the release notes or upgrade notes, though the return value is still technically correct according to the documentation. If the change in behavior was intentional, it may be worth noting somewhere.

PHP Version

PHP 8.2.0alpha2

Operating System

Ubuntu 20.04

[KapitanOczywisty]

Introduced in #8220 , and indeed no mention in UPGRADING

[devnexen]

though the return value is still technically correct why do you think earlier versions are correct ?

[cmb69]

I think we still should document this change; after all, it broke some of our own tests, and likely breaks some userland tests as well (and maybe even production code), even though it is not really a BC break.

[TRowbotham]

though the return value is still technically correct why do you think earlier versions are correct ?

I can't say that the previous behavior is any more correct than the new behavior as they both meet the documented criteria of Returns < 0 if string1 is less than string2; > 0 if string1 is greater than string2. I just happened to have a line of code that was misusing the return value of strcmp causing a test failure in PHP 8.2 alpha 2. As @cmb69 said, its not an actual BC break, but probably still worth noting the change.