Skip to content

compatibility with ICU 72.1 #9799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andypost opened this issue Oct 21, 2022 · 6 comments
Closed

compatibility with ICU 72.1 #9799

andypost opened this issue Oct 21, 2022 · 6 comments

Comments

@andypost
Copy link
Contributor

Description

The following tests are failed for 8.0/8.1/8.2:

FAILED TEST SUMMARY
---------------------------------------------------------------------
IntlDateFormatter, calendars and time zone [ext/intl/tests/dateformat_calendars_variant3.phpt]
IntlDateFormatter::formatObject(): IntlCalendar tests [ext/intl/tests/dateformat_formatObject_calendar_variant5.phpt]
IntlDateFormatter::formatObject(): DateTime tests [ext/intl/tests/dateformat_formatObject_datetime_variant5.phpt]
datefmt_format_code() and datefmt_parse_code() [ext/intl/tests/dateformat_format_parse_version2.phpt]
datefmt_set_timezone_id_code() icu >= 4.8 [ext/intl/tests/dateformat_set_timezone_id3.phpt]
MessageFormatter::format(): DateTime accepted to format dates and times [ext/intl/tests/msgfmt_format_datetime.phpt]
MessageFormatter::format(): simple types handling with numeric strings [ext/intl/tests/msgfmt_format_simple_types_numeric_strings.phpt]
ResourceBundle constructor bundle accepts NULL for first two arguments [ext/intl/tests/resourcebundle_null_mandatory_args_variant2.phpt]

Alpinelinux started upgrade to new ICU and faced with this failures, see https://gitlab.alpinelinux.org/alpine/aports/-/issues/14283

PHP Version

PHP 8.1.11

Operating System

Alpinelinux

@andypost
Copy link
Contributor Author

Looks there's not a lot of changes https://icu.unicode.org/download/72

@cmb69 cmb69 self-assigned this Oct 21, 2022
@andypost
Copy link
Contributor Author

andypost commented Oct 21, 2022

symbol after time is changed

- string(47) "Sunday, January 1, 2012 at 5:12:00 AM GMT+05:12"
+ string(49) "Sunday, January 1, 2012 at 5:12:00 AM GMT+05:12"

EDIT instead of 0x20 before AM now I see 0xE2 0x80 0xAF

@cmb69
Copy link
Member

cmb69 commented Oct 21, 2022

Such changes are not unexpected/unprecedented; in this case the regular space is replaced by NARROW NO-BREAK SPACE. We need to split the affected test cases. I'm already working on a PR.

@cmb69
Copy link
Member

cmb69 commented Oct 21, 2022

@andypost, can you check whether PR #9800 solves the issue for you, or does that need to be merged first?

@andypost
Copy link
Contributor Author

Thank you! Queued the patch to our CI and will report results for 8.2 in ~1h

@andypost
Copy link
Contributor Author

andypost commented Oct 21, 2022

Applies to 7.4 and 8.0 as well except

  • ext/intl/tests/dateformat_create_default.phpt
  • ext/intl/tests/datepatterngenerator_get_best_pattern.phpt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants