Skip to content

Support 8.0 attributes in extension stubs #9967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tillkruss opened this issue Nov 17, 2022 · 5 comments
Closed

Support 8.0 attributes in extension stubs #9967

tillkruss opened this issue Nov 17, 2022 · 5 comments
Labels
Category: Build System Feature Status: Verified

Comments

@tillkruss
Copy link

Description

Hello!

We'd like to use 8.0 attributes in generated arginfo files for our extensions.

it seems that #[\SensitiveParameter] is supported, but that's about not:

namespace MyExtension {
​
  class Foobar {
    
    #[\MyExtension\FooAttribute]
    public function getBaz() {
      //
    }
​
  }

  class FooAttribute { }
​
}
@cmb69
Copy link
Member

cmb69 commented Nov 18, 2022

Supporting arbitrary attributes might open up a can of worms, though.

cc @kocsismate

@tillkruss
Copy link
Author

It seems that as of 8.2 any arbitrary "argument attribute" works, but not "method attributes".

@tillkruss
Copy link
Author

It seems that zend_add_class_attribute and zend_add_parameter_attribute are being generated, but NOT: zend_add_function_attribute

kocsismate added a commit to kocsismate/php-src that referenced this issue Dec 26, 2022
@kocsismate
Fix phpGH-9967 Add support for generating custom function attributes …
b5f14f1 
…in stubs
@kocsismate
Copy link
Member

I've just filed #10170 to implement the feature request.

kocsismate added a commit to kocsismate/php-src that referenced this issue Jan 1, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function attributes …
b2cb072 
…in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Jan 1, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
616e1d3 
…t, and property attributes in stubs
@iluuu1994
Copy link
Member

Closing this as there's a PR for this now (#10170). Please comment there to advance it.

@iluuu1994 iluuu1994 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2023
kocsismate added a commit to kocsismate/php-src that referenced this issue Jun 8, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
0850914 
…t, and property attributes in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Jul 1, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
08ae4dd 
…t, and property attributes in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Jul 2, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
13bb8bb 
…t, and property attributes in stubs
kocsismate added a commit that referenced this issue Jul 3, 2023
@kocsismate
Fix GH-9967 Add support for generating custom function, class const, …
d7ab0ff 
…and property attributes in stubs
kocsismate added a commit that referenced this issue Jul 3, 2023
@kocsismate
Merge branch 'PHP-8.2'
45a3f17 
* PHP-8.2:
  Fix GH-9967 Add support for generating custom function, class const, and property attributes in stubs

Closes GH-10170
iluuu1994 added a commit that referenced this issue Jul 4, 2023
@iluuu1994
Revert "Fix GH-9967 Add support for generating custom function, class…
ef4f088 
… const, and property attributes in stubs"

This reverts commit d7ab0ff.
iluuu1994 added a commit that referenced this issue Jul 4, 2023
@iluuu1994
Merge branch 'PHP-8.2'
779028c 
* PHP-8.2:
  Revert "Fix GH-9967 Add support for generating custom function, class const, and property attributes in stubs"
kocsismate added a commit to kocsismate/php-src that referenced this issue Aug 15, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
b7ba089 
…t, and property attributes in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Aug 15, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
d022d84 
…t, and property attributes in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Aug 15, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
af20108 
…t, and property attributes in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Aug 15, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
78155b4 
…t, and property attributes in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Aug 24, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
fa7464b 
…t, and property attributes in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Aug 24, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
bfe35a0 
…t, and property attributes in stubs
kocsismate added a commit to kocsismate/php-src that referenced this issue Aug 26, 2023
@kocsismate
Fix phpGH-9967 Add support for generating custom function, class cons…
903863d 
…t, and property attributes in stubs
kocsismate added a commit that referenced this issue Aug 26, 2023
@kocsismate
Fix GH-9967 Add support for generating custom function, class const, …
c934e24 
…and property attributes in stubs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Build System Feature Status: Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tillkruss @iluuu1994 @cmb69 @kocsismate